Videojs setup rework - #460
Merged
Merged
Conversation
Dananji
force-pushed
the
videojs-setup-rework
branch
2 times, most recently
from
April 2, 2024 21:06
46ec914 to
65f645d
Compare
Dananji
marked this pull request as ready for review
April 4, 2024 20:47
Dananji
force-pushed
the
videojs-setup-rework
branch
from
April 9, 2024 17:04
c9a2974 to
afe83cc
Compare
…ering, volume panel styling
Dananji
force-pushed
the
videojs-setup-rework
branch
from
April 19, 2024 19:37
afe83cc to
c2933e7
Compare
Dananji
force-pushed
the
videojs-setup-rework
branch
from
April 19, 2024 19:40
771cea4 to
3b8d7b1
Compare
masaball
reviewed
Apr 23, 2024
masaball
left a comment
masaball
left a comment
Contributor
There was a problem hiding this comment.
Overall, this is looking good to me. Just had a couple non-blocking housekeeping things and a question about hopefully simplifying the player update.
Collaborator
Author
Need to squash and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #399