Upgrade Video.js to v8.10.0 - #453
Merged
Merged
Conversation
masaball
force-pushed
the
upgrade-videojs
branch
from
April 18, 2024 17:11
9b1d8c8 to
2a49cf0
Compare
masaball
marked this pull request as ready for review
April 18, 2024 17:13
Dananji
approved these changes
Apr 18, 2024
Dananji
left a comment
Dananji
left a comment
Collaborator
There was a problem hiding this comment.
Looks good as far as I can tell 👍
One thing I noticed missing, is updating the installation instructions inREADME.md, where we have videojs version pinned to 7.*.
I'm not sure whether we should update this now or later when we release this change. What do you think?
Contributor
Author
|
I'm not sure either. It is probably fine to leave the note alone for now and update it at the next release, but then we have to remember to update it. If we want to update now, maybe we could change the note to something like |
In testing the Video.js 8.10.0, it looks like they fixed the root cause of the issues we were seeing with oversized captions in mobile devices. As such, the override that we had put in place was causing the captions to display incorrectly.
masaball
force-pushed
the
upgrade-videojs
branch
from
April 19, 2024 18:50
2a49cf0 to
9922eb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after 3.1.0 release
Related issue: #401
This PR upgrades Video.js to 8.10.0 and @silvermine/videojs-quality-selector to 1.3.1.
In my testing, all of the custom components seemed to be working as I would expect on all platforms once the File Downloader component had been updated to the new format required by Video.js.
I did encounter a change in behavior with captions on mobile devices where the text was covering the video. In Video.js 8.4.0 they implemented a change to force text tracks to overlay the video player. Our custom CSS to override text track size resulted in the overlaid text track being too large in font so I have removed that CSS.