Repository navigation
fix(mcp): archived thread list and scheduled-task default model - #26
Merged
Merged
Conversation
An archive snapshot keeps its rows in archivedThreads, but listProjectThreads read only threads, so t3_thread_list archived:true was always empty. Found by the isolated /mcp E2E run; ThreadManagementService tests pass. Co-Authored-By: Claude Opus 5.5 <[email protected]>
schedule_task from a client outside a thread read only the project record's default model, so it refused even when a global or project settings default was set. It now resolves the project's effective default like t3_thread_launch does. Found by the isolated /mcp E2E run; OrchestratorMcpService, core and context-budget tests pass. Co-Authored-By: Claude Opus 5.5 <[email protected]>
github-actions
Bot
added
vouch:trusted
samnab
added a commit
that referenced
this pull request
Nov 1, 2026
Brings fork PRs #15-#26 (MCP read-back and agent tooling) onto dev, which already carries upstream 15fe283. Resolutions: - ThreadManagementService: list archived threads (origin) and keep the side-chat / isListedThreadLineage filter (upstream). - PeerMcpClient: keep undeclared-argument preflight via startSession (origin) and store the session before the first call so it outlives a waiting or cancelled request (upstream pingdotgg#26567); statusFailure covers 401/403/other. - PeerMcpClient.test (add/add): both suites kept; upstream's scripted renew test now accounts for the tools/list discovery request. - PeerForwarding.test, linkOrigin.test: both new mocks kept, grouped in one Layer.mergeAll to stay within pipe's 20-argument limit. - OrchestratorMcpService.activity.test: Effect.succeedSome per upstream lint rule. - agentContextBudget.json: measured values after merge. - No migrations added by origin/dev; no references to renamed symbols. Checks: vp run typecheck clean in apps/server, packages/contracts, packages/shared, packages/client-runtime, apps/web, apps/mobile. vp test run ThreadManagementService.test, src/mcp, src/peer, src/persistence, AgentContextBudget.test: 67 files, 570 passed. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The isolated
/mcpend-to-end run for API waves 3–5 found two defects.t3_thread_listwitharchived: truealways returned an empty list. An archive snapshot keeps its rows inarchivedThreads, butlistProjectThreadsread onlythreads. It now reads both; thelocationfilter already decides which one is filled.schedule_taskfrom a client outside a thread refused with "no default model" unless the project record itself had one. It ignored the environment default and per-project settings. It now resolves the project's effective default withresolveProjectSettings, the same wayt3_thread_launchdoes.Each fix has a regression test that fails before the change and passes after. ThreadManagementService, OrchestratorMcpService, core toolkit and context-budget tests pass, and the server typecheck is clean.
🤖 Generated with Claude Code