Export types from package.json#20
Merged
samhirtarif merged 1 commit intosamhirtarif:masterfrom Sep 7, 2024
Merged
Conversation
|
Hello, is it possible for this pull request to be merged? It's not possible to import any of the components when using TypeScript and |
|
here's a yarn patch you can use until the author gets back from spending all the internet credits. diff --git a/package.json b/package.json
index 73d831ffb09522160101c69b8fab688823f1eaa7..10992633d9c992045756b455d249cf1bfd9015ea 100644
--- a/package.json
+++ b/package.json
@@ -33,7 +33,8 @@
"exports": {
".": {
"import": "./dist/react-audio-visualize.es.js",
- "require": "./dist/react-audio-visualize.umd.js"
+ "require": "./dist/react-audio-visualize.umd.js",
+ "types": "./dist/index.d.ts"
}
},
"scripts": {chuck it in then update your ...
"dependencies": {
...
"react-audio-visualize": "patch:react-audio-visualize@npm%3A1.1.3#~/.yarn/patches/react-audio-visualize-npm-1.1.3-4843f9e559.patch",
...
},
"resolutions": {
"react-audio-visualize@npm:^1.1.3": "patch:react-audio-visualize@npm%3A1.1.3#~/.yarn/patches/react-audio-visualize-npm-1.1.3-4843f9e559.patch"
}
...
👍🏻 🤝 |
mrsafalpiya
approved these changes
Mar 18, 2024
brenohennrique
approved these changes
Jul 18, 2024
samhirtarif
approved these changes
Sep 7, 2024
Owner
|
@asquithea thanks for this! And sorry for the wait guys! This will be published shortly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes microsoft/TypeScript#52363