Avoid using deprecated parts of the 'url' module. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the pull request! Looks great 👍Merged. |
Owner
|
Just so you know I've released version 2 with this update. Thanks again for the PR! |
Contributor
Author
|
Oh wow, didn't expect you to merge it so fast. Thank you Sam! 🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋
Thank you so much for a wonderful project! We are using it in GoogleChrome/lighthouse in one of the SEO audits.
This PR
Short story: robots-parser uses some 'url' module APIs that are deprecated since Node v6, lets update them!
Long story: Lighthouse runs in both node and browser environments. In the browser we use the native URL object to polyfill
require('url'). Unfortunately, robots-parser was using APIs that are not compatible with the browser's URL object (namelyparseandpath). Thankfully, these APIs are also deprecated in Node, so it does make sense to update them.new URL()we are dropping support for Node v4 here (which is in the maintenance mode till April 2018).