Skip to content

fix: order of GroupBy and PartitionBy#572

Merged
samber merged 1 commit into
samber:masterfrom
liyishuai:parallel-group-partition
Jan 24, 2025
Merged

fix: order of GroupBy and PartitionBy#572
samber merged 1 commit into
samber:masterfrom
liyishuai:parallel-group-partition

Conversation

@liyishuai
Copy link
Copy Markdown

Fix #510

@liyishuai liyishuai force-pushed the parallel-group-partition branch 3 times, most recently from b4905ec to 99875b9 Compare January 7, 2025 09:04
@liyishuai liyishuai force-pushed the parallel-group-partition branch from 99875b9 to d3b5701 Compare January 7, 2025 09:05
@samber
Copy link
Copy Markdown
Owner

samber commented Jan 24, 2025

Thanks for the PR !

I think we need to improve this sub-package !

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.29%. Comparing base (5044a1d) to head (d3b5701).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
- Coverage   94.33%   94.29%   -0.05%     
==========================================
  Files          17       17              
  Lines        2790     2768      -22     
==========================================
- Hits         2632     2610      -22     
  Misses        154      154              
  Partials        4        4              
Flag Coverage Δ
unittests 94.29% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samber samber merged commit 5512d3a into samber:master Jan 24, 2025
@samber samber mentioned this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lop.PartitionBy does not guarantee the same order

2 participants