Implemented GroupByMap#443
Merged
Merged
Conversation
samber
reviewed
Jun 27, 2024
Owner
samber
left a comment
samber
left a comment
There was a problem hiding this comment.
i think we need to think a little bit about the naming
your variant: map then group by
other cool variant I use in my own projects: map then group by then aggregate values
| result := map[K][]V{} | ||
|
|
||
| for _, item := range arr { | ||
| k := iterateeKey(item) |
Owner
There was a problem hiding this comment.
I would use a single iteratee: k, v := iteratee(item)
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a new function to GroupBy.
This Implementation allows to map the values on the same iteration.
Sending an identity function as the
iterateeValuewill de facto result in a normal GroupBy operation.