Adding lo.WaitFor by samber · Pull Request #269 · samber/lo

samber · 2022-11-15T18:02:22Z

ok := WaitFor(func(i int) bool {
	return i % 3 == 2
}, 10*time.Millisecond, time.Millisecond)

codecov-commenter · 2022-11-15T18:24:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.64%. Comparing base (c23c040) to head (173088f).
Report is 76 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   94.00%   94.64%   +0.64%     
==========================================
  Files          16       17       +1     
  Lines        2500     2892     +392     
==========================================
+ Hits         2350     2737     +387     
- Misses        148      154       +6     
+ Partials        2        1       -1

Flag	Coverage Δ
unittests	`94.64% <100.00%> (+0.64%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ccoVeille · 2024-06-28T20:20:33Z

 }
+
+// WaitFor runs periodically until a condition is validated.
+func WaitFor(condition func(i int) bool, maxDuration time.Duration, tick time.Duration) (int, time.Duration, bool) {


What about this

Suggested change

func WaitFor(condition func(i int) bool, maxDuration time.Duration, tick time.Duration) (int, time.Duration, bool) {

func WaitFor(condition func(i int) bool, maxDuration time.Duration, tick time.Duration) (int, time.Duration, bool) {

return WaitForWithCtx(context.Background(), condition, maxDuration, tick)

}

// WaitForWithCtx runs periodically until a condition is validated or context is cancelled

func WaitForWithCtx(ctx context.Context, condition func(i int) bool, maxDuration time.Duration, tick time.Duration) (int, time.Duration, bool) {

if condition(0) {

return 1, 0, true

}

start := time.Now()

timer := time.NewTimer(maxDuration)

ticker := time.NewTicker(tick)

defer func() {

timer.Stop()

ticker.Stop()

}()

i := 1

for {

select {

case <-ctx.Done():

return i, time.Since(start), false

case <-timer.C:

return i, time.Since(start), false

case <-ticker.C:

if condition(i) {

return i + 1, time.Since(start), true

}

i++

}

}

}

Please open a new PR.

I opened

feat: add WaitForWithContext #480

samber force-pushed the feat-concurrency-waitFor branch from d91b023 to 0be7871 Compare June 28, 2024 18:46

feat(concurrency): adding lo.WaitFor

aaebc3f

samber force-pushed the feat-concurrency-waitFor branch from 0be7871 to aaebc3f Compare June 28, 2024 19:05

samber added 3 commits June 28, 2024 21:07

doc

31e7f69

more accurate tests

1880550

Update README.md

173088f

samber merged commit 263c266 into master Jun 28, 2024

ccoVeille reviewed Jun 28, 2024

View reviewed changes

samber deleted the feat-concurrency-waitFor branch June 29, 2024 17:31

ccoVeille mentioned this pull request Jun 29, 2024

feat: add WaitForWithContext #480

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adding lo.WaitFor#269

Adding lo.WaitFor#269
samber merged 4 commits into
masterfrom
feat-concurrency-waitFor

samber commented Nov 15, 2022

Uh oh!

codecov-commenter commented Nov 15, 2022 •

edited by codecov Bot

Loading

Uh oh!

ccoVeille Jun 28, 2024

Uh oh!

ccoVeille Jun 28, 2024

Uh oh!

samber Jun 29, 2024

Uh oh!

ccoVeille Jun 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-func WaitFor(condition func(i int) bool, maxDuration time.Duration, tick time.Duration) (int, time.Duration, bool) {
+func WaitFor(condition func(i int) bool, maxDuration time.Duration, tick time.Duration) (int, time.Duration, bool) {
+       return WaitForWithCtx(context.Background(), condition, maxDuration, tick)
+}
+// WaitForWithCtx runs periodically until a condition is validated or context is cancelled
+ func WaitForWithCtx(ctx context.Context, condition func(i int) bool, maxDuration time.Duration, tick time.Duration) (int, time.Duration, bool) {
+         if condition(0) {
+                 return 1, 0, true
+         }
+         start := time.Now()
+         timer := time.NewTimer(maxDuration)
+         ticker := time.NewTicker(tick)
+         defer func() {
+                 timer.Stop()
+                 ticker.Stop()
+         }()
+         i := 1
+         for {
+                 select {
+                 case <-ctx.Done():
+                         return i, time.Since(start), false
+                 case <-timer.C:
+                         return i, time.Since(start), false
+                 case <-ticker.C:
+                         if condition(i) {
+                                 return i + 1, time.Since(start), true
+                         }
+                         i++
+                 }
+         }
+ }

Uh oh!

Conversation

samber commented Nov 15, 2022

Uh oh!

codecov-commenter commented Nov 15, 2022 • edited by codecov Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ccoVeille Jun 28, 2024

Choose a reason for hiding this comment

Uh oh!

ccoVeille Jun 28, 2024

Choose a reason for hiding this comment

Uh oh!

samber Jun 29, 2024

Choose a reason for hiding this comment

Uh oh!

ccoVeille Jun 29, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-commenter commented Nov 15, 2022 •

edited by codecov Bot

Loading