Repository navigation
fix(test): match jose transform paths on Windows - #1315
Merged
samanhappy merged 1 commit intoOct 12, 2026
Merged
samanhappy merged 1 commit into
samanhappy merged 1 commit into
Conversation
The jose transform introduced by samanhappy#1295 matches only POSIX separators. On Windows, eleven affected suites fail during loading with Unexpected token export, so their tests do not execute. Match both native separator conventions in this transform while keeping its ts-jest CommonJS options and the remaining config unchanged. The eleven affected suites and 168 tests pass on Windows after this change. Other baseline full-suite failures remain outside this fix.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1315 +/- ##
=======================================
Coverage ? 60.36%
=======================================
Files ? 232
Lines ? 19281
Branches ? 4839
=======================================
Hits ? 11639
Misses ? 6065
Partials ? 1577
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
11 of 19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jest cannot load eleven suites on Windows after #1295 added a transform for the ESM-only
josepackage. The rule uses/separators, while Jest passes native Windows paths, so the transform does not match and the suites fail withUnexpected token 'export'before executing their tests.Accept both
/and\at each directory boundary in that rule. The existingts-jestCommonJS transform and options remain the same; the other transforms, module mappings, ignore patterns, dependencies and production code are unchanged.Validation on Windows, Node 22.20.0 and pinned pnpm 10.12.4:
--maxWorkers=2 --no-cache: eleven suites and 168 tests pass. The existing worker teardown warning is still present.josepath pass; the remaining config is identical.The full suite and builds were not rerun during this independent review. No Linux or hosted-CI execution is claimed. This self-discovered portability regression needs no new issue or changes to CI workflows.