Repository navigation
fix: keep on-demand servers alive while tools are running - #1164
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1164 +/- ##
=======================================
Coverage ? 52.47%
=======================================
Files ? 214
Lines ? 17215
Branches ? 4247
=======================================
Hits ? 9034
Misses ? 6782
Partials ? 1399
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tool call that starts shortly before an on-demand server's idle deadline can be interrupted by the previous call's timer. A short concurrent call can also arm that timer while another call is still running, leaving the caller with a connection error after the tool has already performed a write.
Track active calls on the on-demand runtime, cancel idle shutdown before waking or using it, and start the idle period when the last call finishes. Release the count in
finallyso failed calls can still be reclaimed. Preserve the runtime object across configuration reloads so callers and timers share the same state, and keep discovery priming from closing a child that a tool call is using.Fixes #1163.
Validation
pnpm lint,pnpm build, andnode scripts/verify-dist.jspass.pnpm devstarts and connects the test upstream;/healthreturns HTTP 200. After discovery priming puts the upstream to sleep, the health payload reports it as disconnected/degraded.pnpm test:ci --maxWorkers=2: 1468 passed, 15 failed. The same 15 failures reproduce in an unchanged checkout offb60844f975e02de08f42b8849e927428b34fe6f. They include transport tests where the local DNS resolvesexample.comto198.18.0.11, which the existing SSRF check blocks. No additional test failures were introduced.