fix(travis): use version numbers in Gemfile to prevent failed builds #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `kitchen-salt 0.0.21` being installed instead of current latest `0.5.0` - Failing builds since `pillars_from_files` is not recognised - Deprecated `pillars-from-files` is working but not the right solution * Reason: `test-kitchen 2.0.0` was released 3 days ago on March 20, 2019 - `kitchen-salt 0.5.0` depends on `test-kitchen ~> 1.4` - `kitchen-salt 0.0.21` depends on `test-kitchen >= 0`, so gets pulled * Remove `test-kitchen` since it is pulled automatically by the other gems - Allow the correct version to be installed via. dependency resolution
|
🎉 This PR is included in version 1.2.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Mar 23, 2019
myii
added a commit
to myii/systemd-formula
that referenced
this pull request
Mar 24, 2019
* saltstack-formulas/template-formula#81 - Update `Gemfile` inc. remove `serverspec` gems * Fix minor issues in config files
myii
added a commit
to myii/systemd-formula
that referenced
this pull request
Mar 24, 2019
* saltstack-formulas/template-formula#81 - Update `Gemfile` inc. remove `serverspec` gems * saltstack-formulas/template-formula#74 - Replace deprecated `pillars-from-files` with `pillars_from_files` * Fix minor issues in config files
myii
added a commit
to myii/systemd-formula
that referenced
this pull request
Mar 24, 2019
* saltstack-formulas/template-formula#81 - Update `Gemfile` inc. remove `serverspec` gems * saltstack-formulas/template-formula#74 - Replace deprecated `pillars-from-files` with `pillars_from_files` * saltstack-formulas/template-formula#82 - Use `debian:8` again since `python-systemd` now available * Fix minor issues in config files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kitchen-salt 0.0.21being installed instead of current latest0.5.0pillars_from_filesis not recognisedpillars-from-filesis working but not the right solutiontest-kitchen 2.0.0was released 3 days ago on March 20, 2019kitchen-salt 0.5.0depends ontest-kitchen ~> 1.4kitchen-salt 0.0.21depends ontest-kitchen >= 0, so gets pulledtest-kitchensince it is pulled automatically by the other gemsMore detailed explanation on Slack: