Skip to content

ci(travis): include commitlint stage #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
myii merged 3 commits into from
Feb 22, 2019
Merged

ci(travis): include commitlint stage #41

myii merged 3 commits into from
Feb 22, 2019

Conversation

@myii
Copy link
Contributor

@myii myii commented Feb 21, 2019 •
edited
Loading

Notes follow in comments below.

@myii myii requested review from aboe76 and javierbertoli February 21, 2019 17:32
@myii
Copy link
Contributor Author

myii commented Feb 21, 2019

With stages set, any failure in a previous stage, cancels all of the following stages.

Originally had this set up as: commitlint => test => release. However, since the main tests are crucial, those have been put first and the commitlint errors can be checked before preparing the actual release. That's the usual time that a rebase might take place with a PR, so the right time to fix the commit messages.

myii added 2 commits February 21, 2019 17:40
@myii
ci(travis): include commitlint stage
6659a69 
* https://github.com/conventional-changelog/commitlint
  - Lint commit messages.
  - Ensure that they are in accordance with `semantic-release` settings.
  - Use Travis CI to display errors and prevent release stage if so.
* https://conventional-changelog.github.io/commitlint/#/reference-rules
  - Specific rules are defined in `commitlint.config.js`.
  - Using the default rules at the time of this commit.
  - This link gives full details on the default values and how to
    provide custom settings.
@myii
ci(travis): remove obsolete check based on $TRAVIS_TEST_RESULT
6df9c95
@myii
Copy link
Contributor Author

myii commented Feb 21, 2019

IMO, this needs to be merged in before #38 -- that can be rebased afterwards.

@myii myii mentioned this pull request Feb 21, 2019
Merged
@getSurreal
Copy link

getSurreal commented Feb 22, 2019

I was reviewing the commit conventions and was wondering what qualifies as a chore?

build
ci
chore
docs
feat
fix
perf
refactor
revert
style
test

@myii
Copy link
Contributor Author

myii commented Feb 22, 2019

@getSurreal You and everyone else! It is a little confusing.

Anyway, have a look at the table in the CONTRIBUTING file. Basically, these are "bot" or "system" tasks that take place automatically, such as when it calculates the version number bump and updates all of the files automatically.

@myii myii merged commit f9dd953 into saltstack-formulas:master Feb 22, 2019
@myii myii deleted the PR_commitlint branch February 22, 2019 03:31
@myii
Copy link
Contributor Author

myii commented Feb 22, 2019

@javierbertoli @aboe76 I'm going ahead and merging this because I've got a backlog of PRs to submit. This particular PR is not introducing anything major and will be easy to revert in the event of issues.

@saltstack-formulas-travis
Copy link

saltstack-formulas-travis commented Feb 22, 2019

🎉 This PR is included in version 0.3.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@myii myii mentioned this pull request Mar 10, 2019
Open
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javierbertoli javierbertoli Awaiting requested review from javierbertoli

@aboe76 aboe76 Awaiting requested review from aboe76

Assignees

No one assigned

Labels

bump:patch released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@myii @getSurreal @saltstack-formulas-travis