Skip to content

Conversation

@myii
Copy link
Contributor

@myii myii commented Feb 21, 2019

Based on discussions Slack/IRC/Matrix leading to the following plan:

  • Debian:
    • debian-9
    • debian-8
    • ubuntu-18
    • ubuntu-16
  • RedHat:
    • centos-7
    • centos-6
    • fedora
  • Suse:
    • opensuse

WIP because 6/8 are working (the other two have been commented out for now), so need to work out how we want to proceed.

@myii myii requested review from aboe76 and javierbertoli February 21, 2019 01:19
@myii myii added the WIP label Feb 21, 2019
@myii
Copy link
Contributor Author

myii commented Feb 21, 2019

@myii
Copy link
Contributor Author

myii commented Feb 21, 2019

Issues to resolve (or ignore)

centos-6

Not based on systemd so the current tests will always fail. Either we rewrite the tests to work across all 8 platforms or we leave this commented out going forward. I favour the latter, at least for this PR.

Update: Or maybe this is an opportunity to show how to use this feature of .kitchen.yml:

# Below is an example where test suites are segregated by os_family

opensuse

Tried many of the opensuse-based docker images but ended up with the same SSH problem for every one of them:

       Step 17/17 : RUN echo ssh-rsa\ AAAAB3NzaC1yc2EAAAADAQABAAABAQC86g3x8L72M/KTjYtuWehpQim7SU7gF6A1EAe5H7/FbE\+oOTs0Yy3Gj24I65BDa5sZfnAwxNYZW88MReFEM1e09sbsVZU\+1ypTlbTLj/HiVmRehZD77v2pSUatQ/m4zW4taTxoZ1Zm7hEPXPX7DPSm0rke2n3UMVn3AlapDxgmVP83Ko0b454XjwE7NEgFiQUfpHWjXzm0ioVB\+i75P9HdwfiB4jzM371dehaEgq3SanFe3wzR54C/LRqbXUrBIhOmR3wRc7739bbf/jt4kexQhDUZ4BIt9aEW6DNZfOxsq9CABTIPB2CUZmuJuZA5Z\+VHWY9cEynRpvZBhdV4LWHv\ kitchen_docker_key >> /home/kitchen/.ssh/authorized_keys
        ---> Running in d40ec41584dc
        ---> ead2693c2478
       Removing intermediate container d40ec41584dc
       Successfully built ead2693c2478
       2581c932e6287f2cef624d293d203a2d3050b39aaf19e738de1dca6fb08a4041
       0.0.0.0:32768
       Waiting for SSH service on localhost:32768, retrying in 3 seconds
       Waiting for SSH service on localhost:32768, retrying in 3 seconds
       Waiting for SSH service on localhost:32768, retrying in 3 seconds

       ... 

       Waiting for SSH service on localhost:32768, retrying in 3 seconds
       Waiting for SSH service on localhost:32768, retrying in 3 seconds
       Waiting for SSH service on localhost:32768, retrying in 3 seconds
$$$$$$ [SSH] connection failed, terminating (#<Errno::ECONNRESET: Connection reset by peer>)
>>>>>> ------Exception-------
>>>>>> Class: Kitchen::ActionFailed
>>>>>> Message: 1 actions failed.
>>>>>>     Failed to complete #create action: [SSH session could not be established] on default-opensuse

On a related note, opensuse is deprecated:

DEPRECATED - for current images by the openSUSE Project see opensuse/leap and opensuse/tumbleweed.

  • This is reason for using opensuse/leap for this PR.

@myii
Copy link
Contributor Author

myii commented Feb 21, 2019

This still needs to be updated according to our final decisions:

supports:
- os-name: debian
- os-name: centos
- os-name: ubuntu


Another idea to enable centos-6; perhaps use a conditional in:


Getting warnings from travis lint:

[x] unexpected key jobs, dropping
[x] value for env section is empty, dropping
[x] in env section: value for matrix section is empty, dropping
[x] in env.matrix section: unexpected pair

@myii
Copy link
Contributor Author

myii commented Feb 21, 2019

https://kitchen.ci/docs/getting-started/kitchen-yml/:

As of test-kitchen 1.21.0, we now prefer kitchen.yml over .kitchen.yml. This preference applies to kitchen.local.yml as well. This is backward compatible so the dot versions continue to work.

@myii myii force-pushed the PR_kitchen-travis-platforms branch from f30c689 to b3b3969 Compare February 21, 2019 11:33
@myii
Copy link
Contributor Author

myii commented Feb 21, 2019

After a bunch of testing involving @javierbertoli, @noelmcloughlin and some crucial help from @gtmanfred, we now have opensuse-leap working as well!

@myii
Copy link
Contributor Author

myii commented Feb 21, 2019

Currently blocked by #41 -- after that is merged, this can be rebased.

@myii myii force-pushed the PR_kitchen-travis-platforms branch from 011f8a1 to 4982f88 Compare February 22, 2019 03:42
myii added 3 commits February 22, 2019 03:48
Based on discussions in #saltstack-formulas leading to:

* Debian:
  - debian-9
  - debian-8
  - ubuntu-18
  - ubuntu-16
* RedHat:
  - centos-7
  - centos-6
  - fedora
* Suse:
  - opensuse
@myii myii force-pushed the PR_kitchen-travis-platforms branch from 4982f88 to 42f93b3 Compare February 22, 2019 03:50
@myii myii changed the title WIP: ci(kitchen+travis): conduct tests on a wider range of platforms WIP: feat(kitchen+travis): conduct tests on a wider range of platforms Feb 22, 2019
@myii myii changed the title WIP: feat(kitchen+travis): conduct tests on a wider range of platforms feat(kitchen+travis): conduct tests on a wider range of platforms Feb 23, 2019
@myii myii removed the WIP label Feb 23, 2019
@myii
Copy link
Contributor Author

myii commented Feb 23, 2019

@aboe76 @javierbertoli I've removed the WIP tagging and believe this is ready for merge whenever you're ready. A follow-on task would be to find a better solution for centos-6.

@aboe76 aboe76 merged commit 4bdfaae into saltstack-formulas:master Feb 23, 2019
@aboe76
Copy link
Contributor

aboe76 commented Feb 23, 2019

@myii merged it

@myii myii deleted the PR_kitchen-travis-platforms branch February 23, 2019 15:53
@myii
Copy link
Contributor Author

myii commented Feb 23, 2019

@aboe76 Thanks. I'll respond to your comment about the systemd-formula shortly.

@saltstack-formulas-travis

🎉 This PR is included in version 0.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants