Skip to content

test(inspec): readme for default profile and a fix #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
javierbertoli merged 1 commit into from
Jun 16, 2019
Merged

test(inspec): readme for default profile and a fix #141

javierbertoli merged 1 commit into from
Jun 16, 2019

Conversation

@noelmcloughlin
Copy link
Contributor

@noelmcloughlin noelmcloughlin commented Jun 15, 2019

Update default inspec profile structure per guidelines.

README.md should be used to explain the profile, its scope, and usage

Use platform-name to restrict on a specific platform name. ... For compatibility we support os-name and os-family. We recommend all users to change os-name to platform-name and os-family to platform-family.

We will see if unit tests pass ;-)

@noelmcloughlin noelmcloughlin changed the title test(default): readme for default inspec profile and fix test(inspec): readme for default profile and a fix Jun 15, 2019
@noelmcloughlin
Copy link
Contributor Author

noelmcloughlin commented Jun 16, 2019

Hi @javierbertoli are you okay with this too?

javierbertoli
javierbertoli approved these changes Jun 16, 2019
View reviewed changes
Copy link
Member

@javierbertoli javierbertoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

@javierbertoli javierbertoli merged commit 4c5eae9 into saltstack-formulas:master Jun 16, 2019
@javierbertoli
Copy link
Member

javierbertoli commented Jun 16, 2019

Thanks, @noelmcloughlin

@noelmcloughlin
Copy link
Contributor Author

noelmcloughlin commented Jun 16, 2019

Thanks dude @javierbertoli

@noelmcloughlin noelmcloughlin deleted the updated_inspec branch June 16, 2019 23:13
@saltstack-formulas-travis
Copy link

saltstack-formulas-travis commented Jun 16, 2019

🎉 This PR is included in version 3.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@myii
Copy link
Contributor

myii commented Jun 18, 2019 •
edited
Loading

Thanks for this @noelmcloughlin. Just adding the link for future reference:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javierbertoli javierbertoli javierbertoli approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@noelmcloughlin @javierbertoli @saltstack-formulas-travis @myii