Skip to content

Conversation

@n-rodriguez
Copy link
Contributor

No description provided.

@n-rodriguez n-rodriguez requested a review from myii May 12, 2019 23:53
@n-rodriguez n-rodriguez changed the title Add semantic release feat(semantic-release): implement an automated changelog May 13, 2019
Copy link
Contributor

@myii myii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another milestone PR, great work. Just a few minor changes, thanks.

@myii
Copy link
Contributor

myii commented May 25, 2019

@n-rodriguez Are we good to finish this off?

Copy link
Contributor

@myii myii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That template-formula keeps shifting under our feet!

-------

Linux testing is done with ``kitchen-salt``.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get the Requirements sub-section here, as merged in saltstack-formulas/template-formula#123? Of course, if you have anything you want to improve here, please do so.

Gemfile.lock

# copied `.md` files used for conversion to `.rst` using `m2r`
docs/*.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's been another change since in template-formula!

Suggested change
docs/*.md
docs/*.md
# Vim
*.sw?

@myii myii merged commit 3c485ec into saltstack-formulas:master May 26, 2019
@myii
Copy link
Contributor

myii commented May 26, 2019

@n-rodriguez Merged this, there's been plenty of effort already. I'll submit the remaining minor changes in another PR.

@saltstack-formulas-travis

🎉 This PR is included in version 0.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants