Fix UTF issues in 2019.2 #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myii
reviewed
Mar 5, 2019
Contributor
|
@javierbertoli Eyeball check: looks good, thanks. |
myii
suggested changes
Mar 5, 2019
javierbertoli
force-pushed
the
master
branch
2 times, most recently
from
32abeb7 to
faf5397
Compare
myii
reviewed
Mar 6, 2019
myii
reviewed
Mar 6, 2019
myii
reviewed
Mar 6, 2019
myii
reviewed
Mar 6, 2019
javierbertoli
force-pushed
the
master
branch
3 times, most recently
from
37e975a to
ed2d95c
Compare
aboe76
approved these changes
Mar 6, 2019
Contributor
aboe76
left a comment
aboe76
left a comment
There was a problem hiding this comment.
@javierbertoli nice work LGTM
myii
approved these changes
Mar 6, 2019
myii
added a commit
to saltstack-formulas/template-formula
that referenced
this pull request
Mar 6, 2019
* saltstack-formulas/packages-formula#50 (comment) - `pillars-from-files` is deprecated in favor of `pillars_from_files`
Contributor
|
@javierbertoli Appreciate the effort you've put into this, everything looking good. Merged. |
Member
Author
|
Thanks, @myii |
saltstack-formulas-travis
pushed a commit
to saltstack-formulas/template-formula
that referenced
this pull request
Mar 7, 2019
## [1.2.1](v1.2.0...v1.2.1) (2019-03-07) ### Code Refactoring * **kitchen:** `pillars-from-files` => `pillars_from_files` ([7c954a7](7c954a7)), closes [/github.com/saltstack-formulas/packages-formula/pull/50#discussion_r262769817](https://github.com//github.com/saltstack-formulas/packages-formula/pull/50/issues/discussion_r262769817) ### Styles * **map:** use `-` for each Jinja block ([64e3834](64e3834))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #48.
Added new distros to test, following template-formula
Fix/disabled tests where failing (particularly #44)