fix(packages): Python2 libvirt library is unusable by Python3 minion #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
baby-gnu
commented
Jun 7, 2019
baby-gnu
commented
- libvirt/python.sls: mangle the package name when the minion is using Python3
Contributor
Author
|
I need to rework this since it does not work for some distributions. |
We need a mechanism to select which python library to install depending on the environment of the minion. We do not generated keys when the python library is not available for the current OS (like python3 libvirt on CentOS). BREAKING CHANGE: use “osfinger” instead of “codename” to override configuration per distribution version. BREAKING CHANGE: the Python2 package is now “python2_pkg”. * libvirt/python.sls: do nothing when the python package is not available. * libvirt/keys.sls: do nothing when the python package is not available. * libvirt/python.jinja: new macro “switch_python32” to select one of the two arguments based on the environment of the SaltStack minion. * libvirt/map.jinja: update to “template-formula” standards. Import settings from “defaults”, “osfamily”, “os” and “osfinger”. * libvirt/defaults.yaml: distinguish python2 and python3 packages. Use the most common python package name. * libvirt/osfamilymap.yaml: provide setting per OS family. * libvirt/osmap.yaml: CentOS does not have python3 libvirt library. Include Suse specificities. * libvirt/osfingermap.yaml: Suse Leap 42 does not have python3 libvirt library.
baby-gnu
force-pushed
the
bugfix/handle-python-3-salt-minion
branch
from
238c061 to
1a36e5b
Compare
Contributor
Author
|
Instead of mangling the python3 package, I use explicit python2 and python3 package names. |
Contributor
Author
|
This one is needed before merging #35. |
Contributor
Author
|
I'll redo this PR on top of #35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.