Skip to content

Switch to tofs, add some tests #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
myii merged 1 commit into from
May 13, 2019
Merged

Switch to tofs, add some tests #20

myii merged 1 commit into from
May 13, 2019

Conversation

@n-rodriguez
Copy link
Contributor

@n-rodriguez n-rodriguez commented May 10, 2019

No description provided.

@myii
Copy link
Contributor

myii commented May 10, 2019

Just looking at the scope of this PR, isn't it worth starting semantic-release first (or as part of this PR)? Also need to look at why fedora-29 x2 is failing (fedora-28 is passing).

@n-rodriguez
Copy link
Contributor Author

n-rodriguez commented May 11, 2019

Also need to look at why fedora-29 x2 is failing

Fixed! See: https://stackoverflow.com/questions/39323531/why-i-cant-find-ip-vs-module-or-use-ipvsadm-when-i-add-privileged

@n-rodriguez n-rodriguez requested a review from myii May 11, 2019 21:56
@n-rodriguez n-rodriguez self-assigned this May 11, 2019
@n-rodriguez n-rodriguez requested a review from daks May 12, 2019 20:57
@myii myii mentioned this pull request May 12, 2019
Open
71 tasks
myii
myii reviewed May 13, 2019
View reviewed changes
myii
myii reviewed May 13, 2019
View reviewed changes
myii
myii reviewed May 13, 2019
View reviewed changes
myii
myii reviewed May 13, 2019
View reviewed changes
myii
myii reviewed May 13, 2019
View reviewed changes
myii
myii suggested changes May 13, 2019
View reviewed changes
Copy link
Contributor

@myii myii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, just a few minor issues to look at.

@myii
Copy link
Contributor

myii commented May 13, 2019

@n-rodriguez OK, all looking good from the semantic-release point of view. I reckon this PR type is more of a feat than a docs -- what do you think?

@n-rodriguez
Copy link
Contributor Author

n-rodriguez commented May 13, 2019

I reckon this PR type is more of a feat than a docs -- what do you think?

right!

@n-rodriguez
Copy link
Contributor Author

n-rodriguez commented May 13, 2019

So? Can we merge?

@myii
Copy link
Contributor

myii commented May 13, 2019

@n-rodriguez Just waiting for the Travis backlog to clear up, want to ensure that everything is passing before the merge. This PR is running right now.

@myii myii merged commit 015bf8c into saltstack-formulas:master May 13, 2019
@myii
Copy link
Contributor

myii commented May 13, 2019

@n-rodriguez Merged, finally! Now let's hope that the semantic-release user has write permissions on the repo...

@saltstack-formulas-travis
Copy link

saltstack-formulas-travis commented May 13, 2019

🎉 This PR is included in version 0.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@n-rodriguez n-rodriguez deleted the wip/ci branch May 13, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daks daks Awaiting requested review from daks

1 more reviewer

@myii myii myii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@n-rodriguez n-rodriguez

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@n-rodriguez @myii @saltstack-formulas-travis @daks