Skip to content

Conversation

@n-rodriguez
Copy link

Before moving to a new implementation of this formula : #23 (comment)

@n-rodriguez n-rodriguez requested a review from myii August 23, 2019 14:44
@myii
Copy link

myii commented Aug 23, 2019

@n-rodriguez Happy to review when ready. Please ping me again when it's ready to go.

@myii
Copy link

myii commented Aug 23, 2019

@n-rodriguez Also, would you mind using the latest platform matrix from the template-formula?

@aboe76
Copy link

aboe76 commented Aug 23, 2019

@n-rodriguez nice work, looking good, the more formulas get semantic release the better.

@n-rodriguez
Copy link
Author

@myii
Copy link

myii commented Aug 24, 2019

@n-rodriguez Thanks, I'll have a look in the next few hours.

myii added a commit to myii/influxdb-formula that referenced this pull request Aug 24, 2019
Copy link

@myii myii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @n-rodriguez -- some changes suggested and there'll be a further comment after this.

@myii
Copy link

myii commented Aug 24, 2019

@n-rodriguez I left out yamllint changes that are now being used across our semantic-release formulas (see saltstack-formulas/template-formula#159). Shall we leave them for a subsequent PR or are you OK with me adding a commit to this PR?

In terms of test/salt/default/pillar/influxdb.sls, that sort of path is used in a few of our formulas but the majority of our formulas would use test/salt/pillar/influxdb.sls. How do you feel about changing that?

@n-rodriguez n-rodriguez requested a review from myii August 24, 2019 23:24
@n-rodriguez
Copy link
Author

How do you feel about changing that?

I'm ok with that.

@n-rodriguez
Copy link
Author

Shall we leave them for a subsequent PR or are you OK with me adding a commit to this PR?

Feel free to add a commit

* Semi-automated using `ssf-formula` (v0.5.0)
* Fix errors shown below:

```bash
influxdb-formula$ $(grep "\- yamllint" .travis.yml | sed -e "s:^\s\+-\s\(.*\):\1:")
./influxdb/config_defaults.yaml
  1:1       warning  missing document start "---"  (document-start)

./influxdb/defaults.yaml
  1:1       warning  missing document start "---"  (document-start)
  17:24     warning  truthy value should be one of [false, true]  (truthy)

pillar.example
  1:1       warning  missing document start "---"  (document-start)
  4:24      warning  truthy value should be one of [false, true]  (truthy)

test/salt/default/pillar/influxdb.sls
  5:24      warning  truthy value should be one of [false, true]  (truthy)
```
@myii myii merged commit 8f912ab into saltstack-formulas:master Aug 25, 2019
@saltstack-formulas-travis

🎉 This PR is included in version 0.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@myii
Copy link

myii commented Aug 25, 2019

@n-rodriguez It's all merged, thanks for another important PR. I added another commit for yamllint and I also made tiny modifications to the README, so that it matches the template-formula version -- there are some changes that need to be propagated soon, so it makes it easier if everything lines up.

myii added a commit to myii/ssf-formula that referenced this pull request Aug 25, 2019
@n-rodriguez n-rodriguez deleted the wip/sr branch August 25, 2019 14:31
myii added a commit to myii/ssf-formula that referenced this pull request Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants