-
Notifications
You must be signed in to change notification settings - Fork 34
Add semantic-release #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@n-rodriguez Happy to review when ready. Please ping me again when it's ready to go. |
|
@n-rodriguez Also, would you mind using the latest platform matrix from the |
|
@n-rodriguez nice work, looking good, the more formulas get semantic release the better. |
|
@myii @aboe76 I think we're ready to merge :) https://travis-ci.com/saltstack-formulas/influxdb-formula |
|
@n-rodriguez Thanks, I'll have a look in the next few hours. |
* Need to merge before saltstack-formulas#24 since it prevents testing on `develop` * Solution based upon: - saltstack-formulas/vault-formula#35 - saltstack-formulas/users-formula#204
myii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @n-rodriguez -- some changes suggested and there'll be a further comment after this.
|
@n-rodriguez I left out In terms of |
I'm ok with that. |
Feel free to add a commit |
* Semi-automated using `ssf-formula` (v0.5.0) * Fix errors shown below: ```bash influxdb-formula$ $(grep "\- yamllint" .travis.yml | sed -e "s:^\s\+-\s\(.*\):\1:") ./influxdb/config_defaults.yaml 1:1 warning missing document start "---" (document-start) ./influxdb/defaults.yaml 1:1 warning missing document start "---" (document-start) 17:24 warning truthy value should be one of [false, true] (truthy) pillar.example 1:1 warning missing document start "---" (document-start) 4:24 warning truthy value should be one of [false, true] (truthy) test/salt/default/pillar/influxdb.sls 5:24 warning truthy value should be one of [false, true] (truthy) ```
|
🎉 This PR is included in version 0.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
@n-rodriguez It's all merged, thanks for another important PR. I added another commit for |
Before moving to a new implementation of this formula : #23 (comment)