fix(semantic-release): finalise changes from template-formula
#21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 tasks
Author
|
@noelmcloughlin As you may have seen on Slack, the permissions have been fixed and I've forced the release through for #20. The same will have to be done for all PRs in this formula until the tests are fixed. |
Author
|
@noelmcloughlin Are you good with these changes so that we're fully complete with |
noelmcloughlin
approved these changes
Jun 28, 2019
noelmcloughlin
left a comment
noelmcloughlin
left a comment
There was a problem hiding this comment.
Thanks @myii for the hard work. appreciated.
Author
|
Thanks, @noelmcloughlin. |
|
🎉 This PR is included in version 0.3.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@noelmcloughlin These would have been the comments that I added to #20 if I had been able to find time to review that. Note,
semantic-releaseisn't actually working here due to the test failures. And at the time of submitting this, the actual permissions still need to be fixed (ref: https://freenode.logbot.info/saltstack-formulas/20190625#c2310246).