Skip to content

feat(template-formula): adapt template-formula format #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
myii merged 23 commits into from
Jul 3, 2019
Merged

feat(template-formula): adapt template-formula format #10

myii merged 23 commits into from
Jul 3, 2019

Conversation

@noelmcloughlin
Copy link

@noelmcloughlin noelmcloughlin commented Jun 30, 2019

This PR migrates to template-formula format.

This PR also includes some fixes for deepsea.source state (see also upstream)

@noelmcloughlin noelmcloughlin changed the title feat(template-formula): adapt new template-formula format feat(template-formula): adapt template-formula format Jun 30, 2019
myii
myii reviewed Jun 30, 2019
View reviewed changes
Copy link

@myii myii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may not get a chance to check the rest of the changes but everything regarding semantic-release is looking good. Just a few notes to consider, though:

  1. The one inline comment.
  2. The tests need to be fixed, otherwise semantic-release won't run at all!

@noelmcloughlin
Copy link
Author

noelmcloughlin commented Jun 30, 2019 •
edited
Loading

thanks @myii. this PR is aligned to saltstack-formulas/sysstat-formula#12 so should be good for semantic release once I fix your comments above. This formula is only used by me and I'm happy its working good once travis is passing.

@noelmcloughlin noelmcloughlin force-pushed the template-formula branch 10 times, most recently from 1ec0df6 to 91718c9 Compare July 1, 2019 20:16
noelmcloughlin and others added 17 commits July 1, 2019 22:28
@noelmcloughlin
docs(readme): add FreeBSD to readme
96e275a
@noelmcloughlin
feat(integration): update ceph release-name & packages
2db3acc
@noelmcloughlin
refactor(jinja): tidyup indention on jinja rendering
86211e0
@noelmcloughlin
feat(template): migrate to template-formula v3.0.0
4d9e571
@noelmcloughlin
fix(packages): corrected dependency packages & user:group
20b6c31
@noelmcloughlin
fix(source): fixes for building from source
5f7ba72
@noelmcloughlin @myii
docs(contribs): update contributing.rst
d005fb0 
Co-Authored-By: Imran Iqbal <[email protected]>
@noelmcloughlin
fix(map): need osfingermap for debian
c86f76a
@noelmcloughlin
fix(map): update os mappings for centos/fedora
5bd353b
@noelmcloughlin
fix(jinja): pass dict as yaml to jinja renderer
8464691
@noelmcloughlin
fix(example): fix pillar.example version
486f07d
@noelmcloughlin
fix(makefile): fix makefile cut+paste issue
2676182
@noelmcloughlin
fix(python): avoid downgrade to python2
d3e9f03
@noelmcloughlin
fix(redhat): correct python rados package; update kitchen
905d85b
@noelmcloughlin
fix(deps): ensure make is installed
969f2b1
@noelmcloughlin
fix(deps): skip python-boto package on Cent/Suse
06158d3
@noelmcloughlin
test(matrix): use opensuse15 (no py3 on cent6)
26b126f
@noelmcloughlin noelmcloughlin force-pushed the template-formula branch 2 times, most recently from 4d5c65b to f174a52 Compare July 1, 2019 22:16
@noelmcloughlin
Copy link
Author

noelmcloughlin commented Jul 1, 2019

Hi @myii travis CI is passing now (fingers crossed on suse-15 on next run - long story).

What else is needed for a semantic release? Do you need me to squash all the commits for example?

@myii myii mentioned this pull request Jul 2, 2019
Open
71 tasks
@noelmcloughlin noelmcloughlin mentioned this pull request Jul 2, 2019
Closed
@noelmcloughlin
Copy link
Author

noelmcloughlin commented Jul 2, 2019

Resolves #11

@myii
Copy link

myii commented Jul 3, 2019

@noelmcloughlin From a semantic-release perspective, everything appears ready to go. Squashing some/all of the commits is a matter of taste; they will also affect the changelog and release notes (and that cuts both ways, too much or too little). Minor commits (or commits that would be useless to revert) should generally be squashed but I'll leave that to your discretion.

@noelmcloughlin
Copy link
Author

noelmcloughlin commented Jul 3, 2019

The commits are fine as is, as long as it does not make enabling semantic release more difficult.

@aboe76
Copy link

aboe76 commented Jul 3, 2019

@noelmcloughlin and @myii shall I merge this one without squashing?

@noelmcloughlin
Copy link
Author

noelmcloughlin commented Jul 3, 2019

yes I think so if @myii is happy. thanks @aboe76

@noelmcloughlin
Copy link
Author

noelmcloughlin commented Jul 3, 2019

Hopefully Suse Travis CI is fixed too.

@myii
Copy link

myii commented Jul 3, 2019

@aboe76 All clear from my end; as soon as @noelmcloughlin has finished work here, it's ready to go. From the message above, it appears that's the case. Good work!

@myii myii mentioned this pull request Jul 3, 2019
Merged
@noelmcloughlin
Copy link
Author

noelmcloughlin commented Jul 3, 2019

yes. thanks guys

@myii myii merged commit 988f467 into saltstack-formulas:master Jul 3, 2019
@myii
Copy link

myii commented Jul 3, 2019

Merged, thanks for all of the work @noelmcloughlin and to @aboe76 for the prompt!

@myii
Copy link

myii commented Jul 3, 2019

@noelmcloughlin The Release stage failed and I noticed that the GH_TOKEN was missing from Travis so I've rerun that stage after adding it. But we've still got the write permissions issue, so I've made a request on Slack in #formulas. Once that's done, we can rerun that Release stage and all should work fine.

@noelmcloughlin noelmcloughlin deleted the template-formula branch July 3, 2019 21:04
@saltstack-formulas-travis
Copy link

saltstack-formulas-travis commented Jul 8, 2019

🎉 This PR is included in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@myii myii myii left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@noelmcloughlin @myii @aboe76 @saltstack-formulas-travis