Skip to content

Conversation

@myii
Copy link
Contributor

myii commented Mar 14, 2019

@rbjorklin Thanks for your PR. Someone else more familiar with this formula will be along soon to check this in more detail. In the meantime, please use | json instead of | tojson, to be backwards compatible with older, supported minions. Refer back to:

@aboe76 aboe76 requested a review from aabouzaid March 14, 2019 19:55
@rbjorklin
Copy link
Author

Thanks @myii! I was not aware of the json filter and have now updated my PR. Extra big thanks for providing links backing up your point of view! 👍

@aboe76 aboe76 merged commit 5dac1e4 into saltstack-formulas:master Mar 16, 2019
@aboe76
Copy link
Contributor

aboe76 commented Mar 16, 2019

@rbjorklin and @myii thanks merged it

santhoshpg added a commit to propertyguru/rabbitmq-formula-old that referenced this pull request Apr 13, 2020
IndraGunawan pushed a commit to propertyguru/rabbitmq-formula-old that referenced this pull request Apr 26, 2021
* Change repo to bintray

* Include erlang repo

* Add repo for erlang, get distribution from grain

* fix syntax issue

* update erlang repo config

* Add sysctl config file for rabbitmq

* Add sysctl config file

* Add config files

* Update sysctl config

* vhost should be created before policies

* Remove the seperate file we had for production

* Disable default loglevel as debug

* Add shovel config

* Fix config file

* fix incompatible yaml renderer change in 2019.2.0 - saltstack-formulas/consul-formula#40

Co-authored-by: santhoshpg <[email protected]>
IndraGunawan pushed a commit to propertyguru/rabbitmq-formula-old that referenced this pull request Apr 26, 2021
* Change repo to bintray

* Include erlang repo

* Add repo for erlang, get distribution from grain

* fix syntax issue

* update erlang repo config

* Add sysctl config file for rabbitmq

* Add sysctl config file

* Add config files

* Update sysctl config

* vhost should be created before policies

* Remove the seperate file we had for production

* Disable default loglevel as debug

* Add shovel config

* Fix config file

* fix incompatible yaml renderer change in 2019.2.0 - saltstack-formulas/consul-formula#40

Co-authored-by: santhoshpg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants