Skip to content

feat(yamllint): include for this repo and apply rules throughout #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aboe76 merged 1 commit into from
Aug 17, 2019
Merged

feat(yamllint): include for this repo and apply rules throughout #135

aboe76 merged 1 commit into from
Aug 17, 2019
+93 −59

Conversation

@myii
Copy link
Contributor

@myii myii commented Aug 7, 2019

  • Semi-automated using ssf-formula (v0.5.0)
  • Fix (or ignore) errors shown below:
bind-formula$ $(grep "\- yamllint" .travis.yml | sed -e "s:^\s\+-\s\(.*\):\1:")
pillar.example
  1:1       warning  comment not indented like content  (comments-indentation)
  1:89      error    line too long (95 > 88 characters)  (line-length)
  2:1       warning  missing document start "---"  (document-start)
  2:10      error    wrong indentation: expected 0 but found 9  (indentation)
  2:89      error    line too long (103 > 88 characters)  (line-length)
  8:1       error    syntax error: expected '<document start>', but found '<block mapping start>'
  14:89     error    line too long (94 > 88 characters)  (line-length)
  15:51     warning  comment not indented like content  (comments-indentation)
  19:1      error    duplication of key "bind" in mapping  (key-duplicates)
  21:89     error    line too long (93 > 88 characters)  (line-length)
  23:89     error    line too long (102 > 88 characters)  (line-length)
  27:89     error    line too long (96 > 88 characters)  (line-length)
  32:89     error    line too long (143 > 88 characters)  (line-length)
  33:89     error    line too long (134 > 88 characters)  (line-length)
  35:24     error    trailing spaces  (trailing-spaces)
  36:89     error    line too long (91 > 88 characters)  (line-length)
  37:89     error    line too long (93 > 88 characters)  (line-length)
  38:23     warning  truthy value should be one of [false, true]  (truthy)
  39:27     warning  truthy value should be one of [false, true]  (truthy)
  40:27     warning  truthy value should be one of [false, true]  (truthy)
  44:23     warning  truthy value should be one of [false, true]  (truthy)
  45:27     warning  truthy value should be one of [false, true]  (truthy)
  46:27     warning  truthy value should be one of [false, true]  (truthy)
  50:23     warning  truthy value should be one of [false, true]  (truthy)
  51:27     warning  truthy value should be one of [false, true]  (truthy)
  52:27     warning  truthy value should be one of [false, true]  (truthy)
  55:23     warning  truthy value should be one of [false, true]  (truthy)
  56:27     warning  truthy value should be one of [false, true]  (truthy)
  57:27     warning  truthy value should be one of [false, true]  (truthy)
  62:23     warning  truthy value should be one of [false, true]  (truthy)
  63:27     warning  truthy value should be one of [false, true]  (truthy)
  64:27     warning  truthy value should be one of [false, true]  (truthy)
  89:89     error    line too long (91 > 88 characters)  (line-length)
  90:1      warning  comment not indented like content  (comments-indentation)
  97:1      warning  comment not indented like content  (comments-indentation)
  98:89     error    line too long (92 > 88 characters)  (line-length)
  99:51     warning  comment not indented like content  (comments-indentation)
  99:89     error    line too long (96 > 88 characters)  (line-length)
  102:1     warning  comment not indented like content  (comments-indentation)
  102:35    error    trailing spaces  (trailing-spaces)
  103:20    warning  truthy value should be one of [false, true]  (truthy)
  103:89    error    line too long (99 > 88 characters)  (line-length)
  104:51    warning  comment not indented like content  (comments-indentation)
  106:89    error    line too long (99 > 88 characters)  (line-length)
  109:40    error    trailing spaces  (trailing-spaces)
  110:1     error    duplication of key "bind" in mapping  (key-duplicates)
  113:89    error    line too long (115 > 88 characters)  (line-length)
  115:89    error    line too long (110 > 88 characters)  (line-length)
  116:13    error    trailing spaces  (trailing-spaces)
  129:89    error    line too long (120 > 88 characters)  (line-length)
  130:11    error    trailing spaces  (trailing-spaces)
  150:81    error    trailing spaces  (trailing-spaces)
  167:89    error    line too long (118 > 88 characters)  (line-length)
  168:89    error    line too long (101 > 88 characters)  (line-length)
  169:89    error    line too long (103 > 88 characters)  (line-length)
  169:103   error    trailing spaces  (trailing-spaces)
  170:89    error    line too long (107 > 88 characters)  (line-length)
  170:107   error    trailing spaces  (trailing-spaces)
  171:54    warning  comment not indented like content  (comments-indentation)
  171:89    error    line too long (120 > 88 characters)  (line-length)
  172:15    warning  truthy value should be one of [false, true]  (truthy)
  172:89    error    line too long (104 > 88 characters)  (line-length)
  174:21    error    trailing spaces  (trailing-spaces)
  177:15    warning  truthy value should be one of [false, true]  (truthy)
  178:19    error    trailing spaces  (trailing-spaces)
  180:22    error    trailing spaces  (trailing-spaces)
  186:24    warning  truthy value should be one of [false, true]  (truthy)
  186:89    error    line too long (124 > 88 characters)  (line-length)
  191:15    warning  truthy value should be one of [false, true]  (truthy)
  193:89    error    line too long (93 > 88 characters)  (line-length)
  193:93    error    trailing spaces  (trailing-spaces)
  195:89    error    line too long (101 > 88 characters)  (line-length)
  196:89    error    line too long (104 > 88 characters)  (line-length)
  196:104   error    trailing spaces  (trailing-spaces)
  197:15    warning  truthy value should be one of [false, true]  (truthy)
  200:76    error    trailing spaces  (trailing-spaces)
  206:89    error    line too long (94 > 88 characters)  (line-length)
  208:89    error    line too long (94 > 88 characters)  (line-length)
  209:89    error    line too long (98 > 88 characters)  (line-length)
  213:36    error    trailing spaces  (trailing-spaces)
  216:1     error    duplication of key "bind" in mapping  (key-duplicates)
  218:25    warning  truthy value should be one of [false, true]  (truthy)
  221:1     error    too many blank lines (3 > 2)  (empty-lines)
  223:1     error    duplication of key "bind" in mapping  (key-duplicates)
  231:15    warning  truthy value should be one of [false, true]  (truthy)
  231:89    error    line too long (98 > 88 characters)  (line-length)
  232:89    error    line too long (94 > 88 characters)  (line-length)
  234:89    error    line too long (98 > 88 characters)  (line-length)
  235:51    warning  comment not indented like content  (comments-indentation)
  235:89    error    line too long (107 > 88 characters)  (line-length)
  240:15    warning  truthy value should be one of [false, true]  (truthy)
  240:89    error    line too long (98 > 88 characters)  (line-length)
  241:15    warning  truthy value should be one of [false, true]  (truthy)
  241:89    error    line too long (101 > 88 characters)  (line-length)
  242:51    warning  comment not indented like content  (comments-indentation)
  242:89    error    line too long (97 > 88 characters)  (line-length)
  247:15    warning  truthy value should be one of [false, true]  (truthy)
  247:89    error    line too long (98 > 88 characters)  (line-length)
  248:89    error    line too long (99 > 88 characters)  (line-length)
  249:51    warning  comment not indented like content  (comments-indentation)
  249:89    error    line too long (98 > 88 characters)  (line-length)
  253:15    warning  truthy value should be one of [false, true]  (truthy)
  260:89    error    line too long (99 > 88 characters)  (line-length)
  261:15    warning  truthy value should be one of [false, true]  (truthy)
  271:89    error    line too long (96 > 88 characters)  (line-length)
  284:89    error    line too long (109 > 88 characters)  (line-length)
  285:51    warning  comment not indented like content  (comments-indentation)
  285:89    error    line too long (128 > 88 characters)  (line-length)
  286:89    error    line too long (114 > 88 characters)  (line-length)
  287:89    error    line too long (127 > 88 characters)  (line-length)
  289:89    error    line too long (122 > 88 characters)  (line-length)
  290:89    error    line too long (89 > 88 characters)  (line-length)
  291:89    error    line too long (120 > 88 characters)  (line-length)
  292:89    error    line too long (93 > 88 characters)  (line-length)
  293:19    warning  truthy value should be one of [false, true]  (truthy)
  293:24    error    trailing spaces  (trailing-spaces)
  300:89    error    line too long (119 > 88 characters)  (line-length)
  301:51    warning  comment not indented like content  (comments-indentation)
  301:89    error    line too long (122 > 88 characters)  (line-length)
  302:89    error    line too long (93 > 88 characters)  (line-length)
  305:1     error    duplication of key "bind" in mapping  (key-duplicates)
  313:1     warning  comment not indented like content  (comments-indentation)
  313:89    error    line too long (99 > 88 characters)  (line-length)
  320:89    error    line too long (89 > 88 characters)  (line-length)
  337:89    error    line too long (95 > 88 characters)  (line-length)
  341:89    error    line too long (120 > 88 characters)  (line-length)
  345:1     error    too many blank lines (4 > 2)  (empty-lines)
  358:89    error    line too long (89 > 88 characters)  (line-length)
  362:89    error    line too long (117 > 88 characters)  (line-length)
  363:89    error    line too long (89 > 88 characters)  (line-length)
  365:89    error    line too long (102 > 88 characters)  (line-length)
  371:1     error    duplication of key "bind" in mapping  (key-duplicates)

test/salt/pillar/default.sls
  1:1       warning  missing document start "---"  (document-start)
  11:15     warning  truthy value should be one of [false, true]  (truthy)
  16:15     warning  truthy value should be one of [false, true]  (truthy)
  19:15     warning  truthy value should be one of [false, true]  (truthy)
  28:15     warning  truthy value should be one of [false, true]  (truthy)
  114:1     error    too many blank lines (1 > 0)  (empty-lines)

Refer back to: saltstack-formulas/template-formula#159 (comment).

Due to the sheer number of lint errors here, I've used a customised .yamllint file ignoring most of them:

  comments-indentation:
    ignore: |
      pillar.example
  key-duplicates:
    ignore: |
      pillar.example
  line-length:
    ignore: |
      pillar.example

These can be resolved in a subsequent PR, once there's been a discussion about how to fix the situation appropriately. With the ignores, the yamllint passes.

@myii
feat(yamllint): include for this repo and apply rules throughout
a81c9ff 
* Semi-automated using `ssf-formula` (v0.5.0)
* Fix (or ignore) errors shown below:

```bash
bind-formula$ $(grep "\- yamllint" .travis.yml | sed -e "s:^\s\+-\s\(.*\):\1:")
pillar.example
  1:1       warning  comment not indented like content  (comments-indentation)
  1:89      error    line too long (95 > 88 characters)  (line-length)
  2:1       warning  missing document start "---"  (document-start)
  2:10      error    wrong indentation: expected 0 but found 9  (indentation)
  2:89      error    line too long (103 > 88 characters)  (line-length)
  8:1       error    syntax error: expected '<document start>', but found '<block mapping start>'
  14:89     error    line too long (94 > 88 characters)  (line-length)
  15:51     warning  comment not indented like content  (comments-indentation)
  19:1      error    duplication of key "bind" in mapping  (key-duplicates)
  21:89     error    line too long (93 > 88 characters)  (line-length)
  23:89     error    line too long (102 > 88 characters)  (line-length)
  27:89     error    line too long (96 > 88 characters)  (line-length)
  32:89     error    line too long (143 > 88 characters)  (line-length)
  33:89     error    line too long (134 > 88 characters)  (line-length)
  35:24     error    trailing spaces  (trailing-spaces)
  36:89     error    line too long (91 > 88 characters)  (line-length)
  37:89     error    line too long (93 > 88 characters)  (line-length)
  38:23     warning  truthy value should be one of [false, true]  (truthy)
  39:27     warning  truthy value should be one of [false, true]  (truthy)
  40:27     warning  truthy value should be one of [false, true]  (truthy)
  44:23     warning  truthy value should be one of [false, true]  (truthy)
  45:27     warning  truthy value should be one of [false, true]  (truthy)
  46:27     warning  truthy value should be one of [false, true]  (truthy)
  50:23     warning  truthy value should be one of [false, true]  (truthy)
  51:27     warning  truthy value should be one of [false, true]  (truthy)
  52:27     warning  truthy value should be one of [false, true]  (truthy)
  55:23     warning  truthy value should be one of [false, true]  (truthy)
  56:27     warning  truthy value should be one of [false, true]  (truthy)
  57:27     warning  truthy value should be one of [false, true]  (truthy)
  62:23     warning  truthy value should be one of [false, true]  (truthy)
  63:27     warning  truthy value should be one of [false, true]  (truthy)
  64:27     warning  truthy value should be one of [false, true]  (truthy)
  89:89     error    line too long (91 > 88 characters)  (line-length)
  90:1      warning  comment not indented like content  (comments-indentation)
  97:1      warning  comment not indented like content  (comments-indentation)
  98:89     error    line too long (92 > 88 characters)  (line-length)
  99:51     warning  comment not indented like content  (comments-indentation)
  99:89     error    line too long (96 > 88 characters)  (line-length)
  102:1     warning  comment not indented like content  (comments-indentation)
  102:35    error    trailing spaces  (trailing-spaces)
  103:20    warning  truthy value should be one of [false, true]  (truthy)
  103:89    error    line too long (99 > 88 characters)  (line-length)
  104:51    warning  comment not indented like content  (comments-indentation)
  106:89    error    line too long (99 > 88 characters)  (line-length)
  109:40    error    trailing spaces  (trailing-spaces)
  110:1     error    duplication of key "bind" in mapping  (key-duplicates)
  113:89    error    line too long (115 > 88 characters)  (line-length)
  115:89    error    line too long (110 > 88 characters)  (line-length)
  116:13    error    trailing spaces  (trailing-spaces)
  129:89    error    line too long (120 > 88 characters)  (line-length)
  130:11    error    trailing spaces  (trailing-spaces)
  150:81    error    trailing spaces  (trailing-spaces)
  167:89    error    line too long (118 > 88 characters)  (line-length)
  168:89    error    line too long (101 > 88 characters)  (line-length)
  169:89    error    line too long (103 > 88 characters)  (line-length)
  169:103   error    trailing spaces  (trailing-spaces)
  170:89    error    line too long (107 > 88 characters)  (line-length)
  170:107   error    trailing spaces  (trailing-spaces)
  171:54    warning  comment not indented like content  (comments-indentation)
  171:89    error    line too long (120 > 88 characters)  (line-length)
  172:15    warning  truthy value should be one of [false, true]  (truthy)
  172:89    error    line too long (104 > 88 characters)  (line-length)
  174:21    error    trailing spaces  (trailing-spaces)
  177:15    warning  truthy value should be one of [false, true]  (truthy)
  178:19    error    trailing spaces  (trailing-spaces)
  180:22    error    trailing spaces  (trailing-spaces)
  186:24    warning  truthy value should be one of [false, true]  (truthy)
  186:89    error    line too long (124 > 88 characters)  (line-length)
  191:15    warning  truthy value should be one of [false, true]  (truthy)
  193:89    error    line too long (93 > 88 characters)  (line-length)
  193:93    error    trailing spaces  (trailing-spaces)
  195:89    error    line too long (101 > 88 characters)  (line-length)
  196:89    error    line too long (104 > 88 characters)  (line-length)
  196:104   error    trailing spaces  (trailing-spaces)
  197:15    warning  truthy value should be one of [false, true]  (truthy)
  200:76    error    trailing spaces  (trailing-spaces)
  206:89    error    line too long (94 > 88 characters)  (line-length)
  208:89    error    line too long (94 > 88 characters)  (line-length)
  209:89    error    line too long (98 > 88 characters)  (line-length)
  213:36    error    trailing spaces  (trailing-spaces)
  216:1     error    duplication of key "bind" in mapping  (key-duplicates)
  218:25    warning  truthy value should be one of [false, true]  (truthy)
  221:1     error    too many blank lines (3 > 2)  (empty-lines)
  223:1     error    duplication of key "bind" in mapping  (key-duplicates)
  231:15    warning  truthy value should be one of [false, true]  (truthy)
  231:89    error    line too long (98 > 88 characters)  (line-length)
  232:89    error    line too long (94 > 88 characters)  (line-length)
  234:89    error    line too long (98 > 88 characters)  (line-length)
  235:51    warning  comment not indented like content  (comments-indentation)
  235:89    error    line too long (107 > 88 characters)  (line-length)
  240:15    warning  truthy value should be one of [false, true]  (truthy)
  240:89    error    line too long (98 > 88 characters)  (line-length)
  241:15    warning  truthy value should be one of [false, true]  (truthy)
  241:89    error    line too long (101 > 88 characters)  (line-length)
  242:51    warning  comment not indented like content  (comments-indentation)
  242:89    error    line too long (97 > 88 characters)  (line-length)
  247:15    warning  truthy value should be one of [false, true]  (truthy)
  247:89    error    line too long (98 > 88 characters)  (line-length)
  248:89    error    line too long (99 > 88 characters)  (line-length)
  249:51    warning  comment not indented like content  (comments-indentation)
  249:89    error    line too long (98 > 88 characters)  (line-length)
  253:15    warning  truthy value should be one of [false, true]  (truthy)
  260:89    error    line too long (99 > 88 characters)  (line-length)
  261:15    warning  truthy value should be one of [false, true]  (truthy)
  271:89    error    line too long (96 > 88 characters)  (line-length)
  284:89    error    line too long (109 > 88 characters)  (line-length)
  285:51    warning  comment not indented like content  (comments-indentation)
  285:89    error    line too long (128 > 88 characters)  (line-length)
  286:89    error    line too long (114 > 88 characters)  (line-length)
  287:89    error    line too long (127 > 88 characters)  (line-length)
  289:89    error    line too long (122 > 88 characters)  (line-length)
  290:89    error    line too long (89 > 88 characters)  (line-length)
  291:89    error    line too long (120 > 88 characters)  (line-length)
  292:89    error    line too long (93 > 88 characters)  (line-length)
  293:19    warning  truthy value should be one of [false, true]  (truthy)
  293:24    error    trailing spaces  (trailing-spaces)
  300:89    error    line too long (119 > 88 characters)  (line-length)
  301:51    warning  comment not indented like content  (comments-indentation)
  301:89    error    line too long (122 > 88 characters)  (line-length)
  302:89    error    line too long (93 > 88 characters)  (line-length)
  305:1     error    duplication of key "bind" in mapping  (key-duplicates)
  313:1     warning  comment not indented like content  (comments-indentation)
  313:89    error    line too long (99 > 88 characters)  (line-length)
  320:89    error    line too long (89 > 88 characters)  (line-length)
  337:89    error    line too long (95 > 88 characters)  (line-length)
  341:89    error    line too long (120 > 88 characters)  (line-length)
  345:1     error    too many blank lines (4 > 2)  (empty-lines)
  358:89    error    line too long (89 > 88 characters)  (line-length)
  362:89    error    line too long (117 > 88 characters)  (line-length)
  363:89    error    line too long (89 > 88 characters)  (line-length)
  365:89    error    line too long (102 > 88 characters)  (line-length)
  371:1     error    duplication of key "bind" in mapping  (key-duplicates)

test/salt/pillar/default.sls
  1:1       warning  missing document start "---"  (document-start)
  11:15     warning  truthy value should be one of [false, true]  (truthy)
  16:15     warning  truthy value should be one of [false, true]  (truthy)
  19:15     warning  truthy value should be one of [false, true]  (truthy)
  28:15     warning  truthy value should be one of [false, true]  (truthy)
  114:1     error    too many blank lines (1 > 0)  (empty-lines)
```
@aboe76 aboe76 merged commit d23c01f into saltstack-formulas:master Aug 17, 2019
@saltstack-formulas-travis
Copy link

saltstack-formulas-travis commented Aug 17, 2019

🎉 This PR is included in version 0.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@myii @saltstack-formulas-travis @aboe76