Skip to content

Fix CODEOWNERS format; Add Outside Collaborators - #62325

Merged
garethgreenaway merged 2 commits into
saltstack:masterfrom
ScriptAutomate:fix-codeowners
Sep 14, 2022
Merged

garethgreenaway merged 2 commits into
saltstack:masterfrom
ScriptAutomate:fix-codeowners

Conversation

@ScriptAutomate

@ScriptAutomate ScriptAutomate commented Jul 12, 2022 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Related: github/docs#18984

Fixes CODEOWNERS file.

  • Info on CODEOWNERS
  • Main problem: Most of the teams listed did not have at least write permissions (level required to be included) when it came to this repository, or the team didn't exist.

Problems fixed:

  • Following teams don't have proper permissions for repo, and are being excluded
    • @saltstack/team-boto
    • @saltstack/team-cloud
    • @saltstack/team-spm
    • @salstack/team-ssh
    • @saltstack/team-state
    • @saltstack/team-suse (this group is also empty due to conversion of members to Outside Collaborators)
    • @saltstack/team-transport
  • Following teams do not exist
    • @saltstack/team-netapi
    • @saltstack/team-proxy
    • @saltstack/team-code
  • Outside Collaborators were originally added, but are now all removed due to inability for CODEOWNERS to work with members without Write access to the repo:
  • Removed .ci/* as it no longer exists in repo

Previous Behavior

Broken CODEOWNERS file 😢

New Behavior

Functional CODEOWNERS file 😄

Commits signed with GPG?

No

@ScriptAutomate

Copy link
Copy Markdown
Contributor Author

As a follow-up on CODEOWNERS assignment:

It looks like non-VMware employees will not be able to be assigned as code reviewers. GitHub discovered that their documentation was incorrect, and that a reviewer would need to have Write permissions to the repository for GitHub automation to work as expected. Due to only giving Outside Collaborators Read or Triage permissions, we will not be able to have CODEOWNERS automation for the salt repository that includes community members unless GitHub supports this or we try to find an alternative means.

Original GitHub docs (which were incorrect):

The people you choose as code owners must have read permissions for the repository. When the code owner is a team, that team must be visible and it must have write permissions, even if all the individual members of the team already have write permissions directly, through organization membership, or through another team membership.

New GitHub docs mention:

The people you choose as code owners must have write permissions for the repository. When the code owner is a team, that team must be visible and it must have write permissions, even if all the individual members of the team already have write permissions directly, through organization membership, or through another team membership.

At this point, the CODEOWNERS file will only be able to work with VMware-employees, and not community members. I'll leave this up to the open devs to modify as they see fit with VMware employees when it comes to review assignment.

More info:

s0undt3ch
s0undt3ch previously approved these changes Aug 18, 2022
@ScriptAutomate

Copy link
Copy Markdown
Contributor Author

Related GitHub feature request has been opened:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants