Repository navigation
Fix CODEOWNERS format; Add Outside Collaborators - #62325
Conversation
011f9e4 to
9cabf23
Compare
|
As a follow-up on CODEOWNERS assignment: It looks like non-VMware employees will not be able to be assigned as code reviewers. GitHub discovered that their documentation was incorrect, and that a reviewer would need to have Write permissions to the repository for GitHub automation to work as expected. Due to only giving Outside Collaborators Read or Triage permissions, we will not be able to have CODEOWNERS automation for the salt repository that includes community members unless GitHub supports this or we try to find an alternative means. Original GitHub docs (which were incorrect):
New GitHub docs mention:
At this point, the CODEOWNERS file will only be able to work with VMware-employees, and not community members. I'll leave this up to the open devs to modify as they see fit with VMware employees when it comes to review assignment. More info: |
|
Related GitHub feature request has been opened: |
8173f7d to
9563ce3
Compare
What does this PR do?
Fixes
CODEOWNERSfile.CODEOWNERSwritepermissions (level required to be included) when it came to this repository, or the team didn't exist.Problems fixed:
@saltstack/team-boto@saltstack/team-cloud@saltstack/team-spm@salstack/team-ssh@saltstack/team-state@saltstack/team-suse(this group is also empty due to conversion of members to Outside Collaborators)@saltstack/team-transport@saltstack/team-netapi@saltstack/team-proxy@saltstack/team-code.ci/*as it no longer exists in repoPrevious Behavior
Broken
CODEOWNERSfile 😢New Behavior
Functional
CODEOWNERSfile 😄Commits signed with GPG?
No