Skip to content

Fix for issue #25016#25020

Merged
cachedout merged 1 commit intosaltstack:developfrom
martinhoefling:develop
Jun 29, 2015
Merged

Fix for issue #25016#25020
cachedout merged 1 commit intosaltstack:developfrom
martinhoefling:develop

Conversation

@martinhoefling
Copy link
Copy Markdown
Contributor

@martinhoefling martinhoefling commented Jun 27, 2015

Remove iteration over returned minions which is done a couple of lines before in the same function.

@martinhoefling
Copy link
Copy Markdown
Contributor Author

martinhoefling commented Jun 27, 2015

The failed build seems to be a jenkins / ssh issue.

@martinhoefling
Copy link
Copy Markdown
Contributor Author

martinhoefling commented Jun 27, 2015

Can sb. take a look into the failures? They seem to be unrelated to the commit.

@martinhoefling martinhoefling mentioned this pull request Jun 27, 2015
Closed
@jfindlay jfindlay added Core relates to code central or existential to Salt Minor Change Tests-Passed Runners bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch labels Jun 27, 2015
@jfindlay
Copy link
Copy Markdown
Contributor

jfindlay commented Jun 27, 2015

@martinhoefling, thanks for the fix. Next time you are welcome to submit fixes directly to the oldest supported release branch, see https://docs.saltstack.com/en/latest/topics/development/contributing.html#which-salt-branch.

@martinhoefling
Copy link
Copy Markdown
Contributor Author

martinhoefling commented Jun 27, 2015

On 28.06.15 00:47, Justin Findlay wrote:

@martinhoefling, thanks for the fix. Next time you are welcome to submit fixes directly to the oldest supported release branch, see https://docs.saltstack.com/en/latest/topics/development/contributing.html#which-salt-branch.

Damn! Forgot about that...

Best wishes

Martin

@jfindlay
Copy link
Copy Markdown
Contributor

jfindlay commented Jun 28, 2015

No problem, thanks for your work on this.

cachedout pushed a commit that referenced this pull request Jun 29, 2015
Merge pull request #25020 from martinhoefling/develop
cfd904d 
Fix for issue #25016
@cachedout cachedout merged commit cfd904d into saltstack:develop Jun 29, 2015
@rallytime rallytime mentioned this pull request Jul 6, 2015
Merged
@rallytime rallytime added Bugfix - [Done] back-ported and removed bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch labels Jul 6, 2015
jfindlay added a commit that referenced this pull request Jul 6, 2015
@jfindlay
Merge pull request #25175 from rallytime/bp-25020
a9404ae 
Back-port #25020 to 2015.5
@martinhoefling martinhoefling mentioned this pull request Oct 12, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Core relates to code central or existential to Salt Runners Tests-Passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@martinhoefling @jfindlay @cachedout @rallytime