Run fixpoint per strongly connected component (no sync table)#995
Closed
MichaReiser wants to merge 4 commits intosalsa-rs:masterfrom
Closed
Run fixpoint per strongly connected component (no sync table)#995MichaReiser wants to merge 4 commits intosalsa-rs:masterfrom
MichaReiser wants to merge 4 commits intosalsa-rs:masterfrom
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #995 will degrade performances by 12.14%Comparing Summary
Benchmarks breakdown
|
MichaReiser
force-pushed
the
fixpoint-scc
branch
2 times, most recently
from
50a6d5f to
d7e0774
Compare
Contributor
Author
|
Assuming I'm getting this to work. One interesting optimization for |
5 tasks
MichaReiser
changed the title
MichaReiser
force-pushed
the
fixpoint-scc
branch
from
089dfe8 to
6e42e23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run a single fixpoint iteration for strongly connected components
to avoid exponential runtime for deeply nested cycles.
TODO:
maybe_changed_aftercycle_nested_deep_conditional_changed::the_testsometimes hangs or panics