pass Cycle to the cycle recovery function#1028
Merged
MichaReiser merged 16 commits intosalsa-rs:masterfrom Nov 21, 2025
Merged
Conversation
This reverts commit cc35b82.
There was actually no need to run `recover_from_cycle` if the query is converged
This is more ergonomic when sharing `Cycle`
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #1028 will degrade performances by 5.01%Comparing Summary
Benchmarks breakdown
|
mtshiba
commented
Nov 20, 2025
mtshiba
force-pushed
the
expose-cycle-heads
branch
from
7283d5a to
55810e0
Compare
This reverts commit 23b4ba7.
Contributor
Author
|
Hmm, it seems like I'm experiencing a consistent regression, but I'm not sure what the direct cause is. |
Member
|
I think you can ignore those, the regressions are in benchmarks that should be irrelevant to your changes so its likely just noise from code location changes |
MichaReiser
reviewed
Nov 20, 2025
MichaReiser
reviewed
Nov 20, 2025
Contributor
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
This looks good to me, I only have a few nit comments
mtshiba
force-pushed
the
expose-cycle-heads
branch
from
2bb393d to
ada3ed8
Compare
MichaReiser
approved these changes
Nov 21, 2025
Merged
This was referenced Dec 16, 2025
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the cycle recovery function receives the following arguments:
After some consideration, we realized that we needed to expose the IDs of all cycle heads, which meant an additional argument was added, and the current approach of passing all information about the cycle to the cycle recovery function one by one would no longer be desirable. Cycle information that can be passed independently of the query function signature should be passed as a single context structure.
In this PR, we will expose this context as
Cycleand pass it to the cycle recovery function.