fix: use jsdom to parse style attr and serialize it #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Apr 5, 2024
| /> | ||
| <div | ||
| style="background-color: red;" | ||
| style="background-color: red !important;" |
Contributor
Author
There was a problem hiding this comment.
It turns out we don't parse !important correctly in some cases. Opened a separate bug for that: salesforce/lwc#4125
jye-sf
approved these changes
Apr 8, 2024
Contributor
jye-sf
left a comment
jye-sf
left a comment
There was a problem hiding this comment.
Is the change in behavior for ! important worth calling out in a comment?
Contributor
Author
|
When looking at snapshots in core, I don't see anyone actually using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It occurred to me that, instead of regexes, we can use the
elm.styleCSSStyleDeclaration object to serialize out thestyleattribute. This has some benefits:data:base64 URLs correctlyAnd some downsides:
! important(due to the space) and it doesn't seem to like a leading;color: yolo) it will just strip them outbackground-color:#FFFFFF;"becomesbackground-color: rgb(255, 255, 255);I think this is an acceptable tradeoff, especially since it makes the code a lot cleaner.