fix: improve normalization of style attr #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmsjtu
approved these changes
Apr 5, 2024
Member
jmsjtu
left a comment
jmsjtu
left a comment
There was a problem hiding this comment.
Left a comment but otherwise, LGTM!
Comment on lines
+23
to
+26
| .split(':') | ||
| // remove whitespace before `important`, e.g. `! important` -> `!important` | ||
| .map((_) => _.trim().replace(/!\simportant/, '!important')) | ||
| .join(': '), |
Member
There was a problem hiding this comment.
Suggested change
| .split(':') | |
| // remove whitespace before `important`, e.g. `! important` -> `!important` | |
| .map((_) => _.trim().replace(/!\simportant/, '!important')) | |
| .join(': '), | |
| .split(':') | |
| // remove whitespace before `important`, e.g. `! important` -> `!important` | |
| .map((_) => _.trim().replace(/!\simportant/, '!important')) | |
| .filter(Boolean) | |
| .join(': '), |
In case there's duplicate ':' or the string is empty after splitting, like this background-color :: blue.
Could you add a test case for it too?
Contributor
Author
There was a problem hiding this comment.
That would be invalid CSS; I don't think we need to do any special handling for that. If it's invalid, it'll be formatted weirdly. 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve whitespace handling around
:and in! important.