Thanks for flagging this.

The Bug

It looks like on line 68, I'm returning $post_id even though we don't have (or need that value), which is causing the error to be logged.

modify-comment-parent/modify-comment-parent.php

Lines 61 to 74 in 3352562

    
           if ( ! $comment_id ) { 
        
           	// We don't have a comment to modify, make no changes. 
        
           	return; 
        
           } 
        
           if ( ! $nonce ) { 
        
           	// We do not have a nonce value, make no changes. 
        
           	return $post_id; 
        
           } 
        
           if ( ! wp_verify_nonce( $nonce, 'fe_modify_comment_parent' ) ) { 
        
           	// Our nonce value does not match the value we set, make no changes. 
        
           	return; 
        
           }

Difficultly Reproducing

I'm having trouble reproducing this error. The only way I've found thus far is listed below but this is rather artificial.

I'm wondering if there are any other plugins at play.

Regardless, I'll make this update here.

Reproduction Steps

Open a comment for editing, e.g.

Open the browser console and run

document.getElementById('fe_modify_comment_parent_nonce').remove()

Then click Update

	if ( ! $comment_id ) {
	// We don't have a comment to modify, make no changes.
	return;
	}

	if ( ! $nonce ) {
	// We do not have a nonce value, make no changes.
	return $post_id;
	}

	if ( ! wp_verify_nonce( $nonce, 'fe_modify_comment_parent' ) ) {
	// Our nonce value does not match the value we set, make no changes.
	return;
	}

Undefined variable post_id (PHP Notice) #6

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions