Change attribute retrieval to use IS_INSTANCEOF#87
Merged
tabuna merged 1 commit intosajya:masterfrom Mar 26, 2026
Merged
Conversation
Add the ability to inherit from `\Sajya\Server\Attributes\RpcMethod` in order to add custom attributes.
csavelief
added a commit
to computablefacts/cywise
that referenced
this pull request
Mar 25, 2026
…d with the subclassed RpcMethod. This commit should be reverted as soon as this pull-request is accepted: sajya/server#87
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #87 +/- ##
=========================================
Coverage 99.78% 99.78%
Complexity 134 134
=========================================
Files 24 24
Lines 456 456
=========================================
Hits 455 455
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to inherit from
\Sajya\Server\Attributes\RpcMethodin order to add custom attributes.