Skip to content

Conversation

@m1cr0man
Copy link
Contributor

Connects to #72
Connects to #48
Fixes #42

The new friendly URLs code didn't work at all, so I rewrote it. It now takes into account the settings defined in conf.lua, and also removes the other dependencies.

Also, the wrong sailor.path was being selected out of r.filename due to the use of .- instead of .*. A nice consequence of this change is that you don't need to know what the r.uri is, and so it has been removed from the expression.

@m1cr0man m1cr0man changed the title Improve NginX support Improve Nginx support Mar 15, 2016
@Etiene
Copy link
Member

Etiene commented May 28, 2016

Hey! Sorry for the long time it took me to review this. Unfortunately I can't merge this pull request because the friendly urls are not working! (At least not for me)
I think we need some automated tests for this!

The problem was on my end! Merging :)
I still think we need some automated tests for this though!

@Etiene Etiene merged commit 2e95211 into sailorproject:master May 28, 2016
@Etiene
Copy link
Member

Etiene commented May 28, 2016

Thanks for the awesome PR 👯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants