Skip to content

Conversation

@waldyrious
Copy link
Contributor

@waldyrious waldyrious commented Oct 16, 2022

In RST, text wrapped in a `single backtick` is meant for "interpreted text", and is rendered using <cite> tags. Verbatim/literal text should instead be wrapped in ``double backticks``, which is rendered using <code> tags.

See https://docutils.sourceforge.io/docs/user/rst/quickref.html#inline-markup

In RST, text wrapped in a `single backtick` is meant for "interpreted text", and is rendered using <cite> tags.
Verbatim/literal text should instead be wrapped in ``double backticks``, which is rendered using <code> tags.

See https://docutils.sourceforge.io/docs/user/rst/quickref.html#inline-markup
@waldyrious
Copy link
Contributor Author

Note: I only checked the docs/tutorial.rst file; it's possible that there are other files in the documentation with the same issue.

@cebtenzzre
Copy link
Contributor

cebtenzzre commented Oct 16, 2022

Based on the output of

grep -Prn '(^|[^`_])`[^`_][^`]*(?<!_)`([^`_]|$)' --include='*.rst'

this issue is also present in testing.rst, translators.rst, the manpage, and the README.

@waldyrious
Copy link
Contributor Author

@cebtenzzre thanks for looking that up! Would you like write access to my fork so you could make the changes to the other files?

@cebtenzzre
Copy link
Contributor

Looks like I already had access. I pushed fixes for those files, and I also corrected a few references in the manpage (e.g. fdupes(1)) that I think are legitimate use of interpreted text - some of them were using inline literals. How do those changes look to you?

@waldyrious
Copy link
Contributor Author

Looks like I already had access.

Oh, right, it didn't occur to me to check that you had collaborator status in this repo. In that case, yeah, it's expected that you would have write access to the PR branch.

I pushed fixes for those files, and I also corrected a few references in the manpage (e.g. fdupes(1)) that I think are legitimate use of interpreted text - some of them were using inline literals. How do those changes look to you?

Looks great! I confess I'm not 100% sure about when the interpreted text markup is supposed to be used, but those command references definitely don't look like things that should be marked up as code/verbatim.

Thanks for taking this on!

vassilit
vassilit previously approved these changes Mar 3, 2025
@vassilit vassilit self-requested a review March 3, 2025 17:56
@vassilit vassilit dismissed their stale review March 3, 2025 17:58

Upon consideration, there are places where the single backticks would be more appropriate.

@vassilit vassilit merged commit 52b2fef into sahib:master Mar 6, 2025
@waldyrious waldyrious deleted the patch-1 branch March 6, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants