Never hardcode compiler, select it based on CC environment variable #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@cebtenzzre please let me know if you can take a look at this before the next release. I'd be really happy if we could reduce the number of patches required to make the package work on Gentoo: |
Contributor
Author
|
@cebtenzzre I see that this was not merged in time for the new release so I'll have to keep the patch on Gentoo. Any chance you could look into this please? |
Contributor
|
Now that I've had experience getting one release out, the next one will come sooner. I can make sure this gets merged soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids problems where
gcc/ccis not the prefered compiler.