Skip to content

enable configuration options to enable/disable different authentication providers#59

Merged
sahat merged 3 commits into
sahat:masterfrom
seafoodbuffet:configurable_auth
Feb 10, 2014
Merged

enable configuration options to enable/disable different authentication providers#59
sahat merged 3 commits into
sahat:masterfrom
seafoodbuffet:configurable_auth

Conversation

@seafoodbuffet

Copy link
Copy Markdown
Contributor

No description provided.

@sahat

sahat commented Feb 8, 2014

Copy link
Copy Markdown
Owner

@seafoodbuffet I will merge this PR tomorrow. There are few things I wanted to modify first. Instead of facebookAuth: true, githubAuth: true, etc. scattered throughout secrets.js, have an object auth = {} that contains facebook, github, google, twitter, local booleans. Or perhaps an array of strings. But object would be easier to check for presence of authentication methods.

@sahat

sahat commented Feb 10, 2014

Copy link
Copy Markdown
Owner

@seafoodbuffet I will fix it this time, but in the future could you use spaces instead of tabs in Jade templates? If you mix both, it will throw a 500 error: Invalid indentation, you can use tabs or spaces but not both.

@sahat sahat merged commit fb7b2bc into sahat:master Feb 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants