remove deprecated stuff in modular/hecke#41430
Merged
vbraun merged 3 commits intosagemath:developfrom Jan 14, 2026
Merged
Conversation
tobiasdiez
approved these changes
Jan 12, 2026
tobiasdiez
added
s: positive review
s: needs work
and removed
s: needs review
s: positive review
labels
Contributor
|
CI fails: ImportError: cannot import name 'is_HeckeModuleHomspace' from 'sage.modular.hecke.homspace' |
|
Documentation preview for this PR (built with commit 65a7341; changes) is ready! 🎉 |
Contributor
Author
|
thanks, now corrected |
Contributor
|
Rare occurrences of completely green CI 🦊 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 13, 2026
sagemathgh-41430: remove deprecated stuff in modular/hecke after sagemath#37895 ; Closed Date: 2024-05-25 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41430 Reported by: Frédéric Chapoton Reviewer(s): Tobias Diez
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after #37895 ; Closed Date: 2024-05-25
📝 Checklist