Skip to content

Comments

Deprecate is_Ideal, is_LaurentSeries, is_MPolynomialIdeal, is_MPolynomialRing, is_MPowerSeries, is_PolynomialQuotientRing, is_PolynomialRing, is_PolynomialSequence, is_PowerSeries, is_QuotientRing#38266

Merged
vbraun merged 22 commits intosagemath:developfrom
mkoeppe:is_QuotientRing_deprecation
Aug 3, 2024
Merged

Conversation

@mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 23, 2024 •
edited
Loading

Part of:

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

vboxuser and others added 9 commits June 4, 2024 11:23
Fixing issue 38012
34a5f92
Added comment saying purpose of change and reformated polynomial
9d5a23a
@Nathabolin @S17A05
Update src/sage/dynamics/arithmetic_dynamics/projective_ds.py
7f64cf8 
Co-authored-by: Sebastian A. Spindler <[email protected]>
@Nathabolin @S17A05
Update src/sage/dynamics/arithmetic_dynamics/projective_ds.py
8c97c99 
Co-authored-by: Sebastian A. Spindler <[email protected]>
@Nathabolin
Merge branch 'develop' into 38012
8a233f4
@mkoeppe
for a in "CLASS='Ideal|PolynomialSequence|PolynomialQuotientRing';SUF…
ae8699d 
…FIX=_generic" "CLASS='MPolynomialRing';SUFFIX=_base" "CLASS='QuotientRing';SUFFIX=_nc" "CLASS='LaurentSeries|MPowerSeries|MPolynomialIdeal|PowerSeries';SUFFIX=" ; do eval "$a"; git --no-pager grep -l -E 'is_('$CLASS')' src/sage | xargs sed -E -i.bak 's/import is_('$CLASS')/import \1'$SUFFIX'/;/^ +/s/is_('$CLASS')[(]([^()]*([(][^()]*[)])?[^()]*)[)]/isinstance(\2, \1'$SUFFIX')/g'; done
@mkoeppe
for a in "CLASS='PolynomialRing';SUFFIX=_general" ; do eval "$a"; git…
acf326c 
… --no-pager grep -l -E 'is_('$CLASS')' src/sage | xargs sed -E -i.bak 's/import is_('$CLASS')/import \1'$SUFFIX'/;/^ +/s/is_('$CLASS')[(]([^()]*([(][^()]*[)])?[^()]*)[)]/isinstance(\2, \1'$SUFFIX')/g'; done
@mkoeppe
Fixups
52442e8
@mkoeppe
src/sage/rings/polynomial/polynomial_element.pyx: Fix up
d99754c
@github-actions
Copy link

github-actions bot commented Jun 23, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 6a16461; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

kwankyu
kwankyu approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 24, 2024

Thank you!

@vbraun
Copy link
Member

vbraun commented Jul 20, 2024

Tests fail with #38151

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 22, 2024

The test failure is a well-known sporadic timeout.
Back to positive.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jul 25, 2024
9318847 
sagemathgh-38266: Deprecate `is_Ideal`, `is_LaurentSeries`, `is_MPolynomialIdeal`, `is_MPolynomialRing`, `is_MPowerSeries`, `is_PolynomialQuotientRing`, `is_PolynomialRing`, `is_PolynomialSequence`, `is_PowerSeries`, `is_QuotientRing`
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Part of:
- sagemath#32414


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#38151 (merged here)
    
URL: sagemath#38266
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Jul 31, 2024
d7bd310 
sagemathgh-38266: Deprecate `is_Ideal`, `is_LaurentSeries`, `is_MPolynomialIdeal`, `is_MPolynomialRing`, `is_MPowerSeries`, `is_PolynomialQuotientRing`, `is_PolynomialRing`, `is_PolynomialSequence`, `is_PowerSeries`, `is_QuotientRing`
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Part of:
- sagemath#32414


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#38151 (merged here)
    
URL: sagemath#38266
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 2, 2024
c9aceab 
sagemathgh-38266: Deprecate `is_Ideal`, `is_LaurentSeries`, `is_MPolynomialIdeal`, `is_MPolynomialRing`, `is_MPowerSeries`, `is_PolynomialQuotientRing`, `is_PolynomialRing`, `is_PolynomialSequence`, `is_PowerSeries`, `is_QuotientRing`
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Part of:
- sagemath#32414


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#38151 (merged here)
    
URL: sagemath#38266
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 2, 2024
6e943f1 
sagemathgh-38290: Deprecate `is_LaurentSeriesRing`, `is_MPowerSeriesRing`, `is_PowerSeriesRing`
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Part of
- sagemath#32414

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#38266 (merged here)
    
URL: sagemath#38290
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 3, 2024
8bc2d84 
sagemathgh-38290: Deprecate `is_LaurentSeriesRing`, `is_MPowerSeriesRing`, `is_PowerSeriesRing`
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Part of
- sagemath#32414

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#38266 (merged here)
    
URL: sagemath#38290
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
@vbraun vbraun merged commit a1e954b into sagemath:develop Aug 3, 2024
@fchapoton fchapoton mentioned this pull request Jan 16, 2026
Merged
3 tasks
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 24, 2026
3d138b2 
sagemathgh-41460: remove some deprecated stuff in rings/polynomials
    
after

sagemath#34000 ; Closed Date: 2023-03-26
sagemath#37035 ; Closed Date: 2024-02-02
sagemath#38266 ; Closed Date: 2024-08-03
sagemath#37170 ; Closed Date: 2024-02-13
sagemath#36396 ; Closed Date: 2024-02-02
sagemath#32709 ; Closed Date: 2023-03-13

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
    
URL: sagemath#41460
Reported by: Frédéric Chapoton
Reviewer(s): Tobias Diez
@r-mb r-mb mentioned this pull request Feb 5, 2026
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kwankyu kwankyu kwankyu approved these changes

Assignees

@mkoeppe mkoeppe

Labels

t: refactoring v: large

Projects

None yet

Milestone

sage-10.5

Development

Successfully merging this pull request may close these issues.

4 participants

@mkoeppe @vbraun @kwankyu @Nathabolin