Skip to content

Comments

sage.libs.pynac: Remove, deprecated in #32386 (2021)#37873

Merged
vbraun merged 1 commit intosagemath:developfrom
mkoeppe:sage_libs_pynac_remove
May 25, 2024
Merged

sage.libs.pynac: Remove, deprecated in #32386 (2021)#37873
vbraun merged 1 commit intosagemath:developfrom
mkoeppe:sage_libs_pynac_remove

Conversation

@mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Apr 25, 2024

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 7785492; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

kwankyu
kwankyu approved these changes May 18, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 18, 2024

Thanks!

@vbraun vbraun merged commit e8b7fbb into sagemath:develop May 25, 2024
@antonio-rojas
Copy link
Contributor

antonio-rojas commented May 25, 2024

This is causing multiple test failures here

sage -t --long /usr/lib/python3.12/site-packages/sage/groups/misc_gps/argument_groups.py  # 6 doctests failed
sage -t --long /usr/lib/python3.12/site-packages/sage/interfaces/gp.py  # 1 doctest failed
sage -t --long /usr/lib/python3.12/site-packages/sage/libs/pari/tests.py  # 2 doctests failed
sage -t --long /usr/lib/python3.12/site-packages/sage/rings/lazy_series.py  # 2 doctests failed
sage -t --long /usr/lib/python3.12/site-packages/sage/rings/lazy_series_ring.py  # 2 doctests failed
sage -t --long /usr/lib/python3.12/site-packages/sage/rings/qqbar.py  # 1 doctest failed
sage -t --long /usr/lib/python3.12/site-packages/sage/rings/padics/padic_generic_element.pyx  # 2 doctests failed
sage -t --long /usr/lib/python3.12/site-packages/sage/stats/basic_stats.py  # 2 doctests failed
sage -t --long /usr/lib/python3.12/site-packages/sage/stats/distributions/discrete_gaussian_lattice.py  # Timed out (and interrupt failed)

eg. on the first file:

sage -t --long --random-seed=165638275945038594370995858313379188724 /usr/lib/python3.12/site-packages/sage/groups/misc_gps/argument_groups.py
**********************************************************************
File "/usr/lib/python3.12/site-packages/sage/groups/misc_gps/argument_groups.py", line 258, in sage.groups.misc_gps.argument_groups.AbstractArgument._act_on_
Failed example:
    _.parent()
Expected:
    Symbolic Ring
Got:
    <class 'sage.symbolic.ring.SymbolicRing'>
**********************************************************************
File "/usr/lib/python3.12/site-packages/sage/groups/misc_gps/argument_groups.py", line 262, in sage.groups.misc_gps.argument_groups.AbstractArgument._act_on_
Failed example:
    _.parent()
Exception raised:
    Traceback (most recent call last):
      File "/usr/lib/python3.12/site-packages/sage/doctest/forker.py", line 714, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/usr/lib/python3.12/site-packages/sage/doctest/forker.py", line 1146, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.groups.misc_gps.argument_groups.AbstractArgument._act_on_[10]>", line 1, in <module>
        _.parent()
    TypeError: unbound method SageObject.parent() needs an argument
**********************************************************************
File "/usr/lib/python3.12/site-packages/sage/groups/misc_gps/argument_groups.py", line 1116, in sage.groups.misc_gps.argument_groups.ArgumentByElement._symbolic_
Failed example:
    _.parent()
Exception raised:
    Traceback (most recent call last):
      File "/usr/lib/python3.12/site-packages/sage/doctest/forker.py", line 714, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/usr/lib/python3.12/site-packages/sage/doctest/forker.py", line 1146, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.groups.misc_gps.argument_groups.ArgumentByElement._symbolic_[2]>", line 1, in <module>
        _.parent()
        ^^^^^^^^
    AttributeError: 'int' object has no attribute 'parent'
**********************************************************************
File "/usr/lib/python3.12/site-packages/sage/groups/misc_gps/argument_groups.py", line 1153, in sage.groups.misc_gps.argument_groups.ArgumentByElement.__pow__
Failed example:
    _.parent()
Exception raised:
    Traceback (most recent call last):
      File "/usr/lib/python3.12/site-packages/sage/doctest/forker.py", line 714, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/usr/lib/python3.12/site-packages/sage/doctest/forker.py", line 1146, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.groups.misc_gps.argument_groups.ArgumentByElement.__pow__[2]>", line 1, in <module>
        _.parent()
        ^^^^^^^^
    AttributeError: 'int' object has no attribute 'parent'
**********************************************************************
File "/usr/lib/python3.12/site-packages/sage/groups/misc_gps/argument_groups.py", line 1158, in sage.groups.misc_gps.argument_groups.ArgumentByElement.__pow__
Failed example:
    _.parent()
Exception raised:
    Traceback (most recent call last):
      File "/usr/lib/python3.12/site-packages/sage/doctest/forker.py", line 714, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/usr/lib/python3.12/site-packages/sage/doctest/forker.py", line 1146, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.groups.misc_gps.argument_groups.ArgumentByElement.__pow__[3]>", line 1, in <module>
        _.parent()
        ^^^^^^^^
    AttributeError: 'int' object has no attribute 'parent'
**********************************************************************
File "/usr/lib/python3.12/site-packages/sage/groups/misc_gps/argument_groups.py", line 1522, in sage.groups.misc_gps.argument_groups.Sign._act_on_
Failed example:
    _.parent()
Expected:
    Symbolic Ring
Got:
    <class 'sage.rings.complex_mpfr.ComplexField_class_with_category'>
**********************************************************************

@antonio-rojas
Copy link
Contributor

antonio-rojas commented May 25, 2024

The issue is related to the # needs sage.symbolic doctest tag. It seems all lines with this tag are simply not being processed.

@antonio-rojas
Copy link
Contributor

antonio-rojas commented May 25, 2024 •
edited
Loading

#38081

Wonder why this breakage was not detected by CI

@antonio-rojas antonio-rojas mentioned this pull request May 25, 2024
Merged
vbraun pushed a commit to vbraun/sage that referenced this pull request May 26, 2024
ae299a8 
sagemathgh-38081: Fix sage.symbolic feature after libs/pynac removal
    
Fixes
sagemath#37873 (comment)
    
URL: sagemath#38081
Reported by: Antonio Rojas
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request May 27, 2024
d103ca3 
sagemathgh-38081: Fix sage.symbolic feature after libs/pynac removal
    
Fixes
sagemath#37873 (comment)
    
URL: sagemath#38081
Reported by: Antonio Rojas
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request May 29, 2024
a2115ee 
sagemathgh-38081: Fix sage.symbolic feature after libs/pynac removal
    
Fixes
sagemath#37873 (comment)
    
URL: sagemath#38081
Reported by: Antonio Rojas
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request May 31, 2024
5958e5f 
sagemathgh-38081: Fix sage.symbolic feature after libs/pynac removal
    
Fixes
sagemath#37873 (comment)
    
URL: sagemath#38081
Reported by: Antonio Rojas
Reviewer(s):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kwankyu kwankyu kwankyu approved these changes

Assignees

@mkoeppe mkoeppe

Labels

t: refactoring v: minimal

Projects

None yet

Milestone

sage-10.4

Development

Successfully merging this pull request may close these issues.

4 participants

@mkoeppe @antonio-rojas @kwankyu @vbraun