FreeModuleHomset: Create subclass FreeModuleEndset, add element methods for invariants det, charpoly, fcp, etc.#37831
Merged
vbraun merged 8 commits intosagemath:developfrom May 12, 2024
Conversation
|
Documentation preview for this PR (built with commit 1fab17d; changes) is ready! 🎉 |
tscrim
requested changes
Apr 22, 2024
Collaborator
tscrim
left a comment
tscrim
left a comment
There was a problem hiding this comment.
The __classcall_private__ needs a doctest. Otherwise LGTM.
Contributor
Author
Thanks for catching this, done in abc6572 |
Contributor
Author
|
Thank you! |
egourgoulhon
suggested changes
Apr 24, 2024
Member
egourgoulhon
left a comment
egourgoulhon
left a comment
There was a problem hiding this comment.
LGTM as well. I have only minor suggestions.
Contributor
Author
|
Thanks a lot for these edits! |
…subclass FreeModuleEndset
Co-authored-by: Eric Gourgoulhon <[email protected]>
Contributor
Author
|
trivial rebase |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 4, 2024
sagemathgh-37831: `FreeModuleHomset`: Create subclass `FreeModuleEndset`, add element methods for invariants `det`, `charpoly`, `fcp`, etc. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> We create - a parent subclass `FreeModuleEndset` (of `FreeModuleHomset`) - an element subclass `FiniteRankFreeModuleEndomorphism` (of `FiniteRankFreeModuleMorphism`) for the purpose of providing specific methods of endomorphisms, namely the endomorphism invariants `det`, `trace`, `charpoly`, etc. This is parallel to what is done - for ModulesWithBasis in sagemath#37731 - in sagemath#37826 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37831 Reported by: Matthias Köppe Reviewer(s): Eric Gourgoulhon, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 9, 2024
sagemathgh-37831: `FreeModuleHomset`: Create subclass `FreeModuleEndset`, add element methods for invariants `det`, `charpoly`, `fcp`, etc. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> We create - a parent subclass `FreeModuleEndset` (of `FreeModuleHomset`) - an element subclass `FiniteRankFreeModuleEndomorphism` (of `FiniteRankFreeModuleMorphism`) for the purpose of providing specific methods of endomorphisms, namely the endomorphism invariants `det`, `trace`, `charpoly`, etc. This is parallel to what is done - for ModulesWithBasis in sagemath#37731 - in sagemath#37826 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37831 Reported by: Matthias Köppe Reviewer(s): Eric Gourgoulhon, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 11, 2024
sagemathgh-37831: `FreeModuleHomset`: Create subclass `FreeModuleEndset`, add element methods for invariants `det`, `charpoly`, `fcp`, etc. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> We create - a parent subclass `FreeModuleEndset` (of `FreeModuleHomset`) - an element subclass `FiniteRankFreeModuleEndomorphism` (of `FiniteRankFreeModuleMorphism`) for the purpose of providing specific methods of endomorphisms, namely the endomorphism invariants `det`, `trace`, `charpoly`, etc. This is parallel to what is done - for ModulesWithBasis in sagemath#37731 - in sagemath#37826 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37831 Reported by: Matthias Köppe Reviewer(s): Eric Gourgoulhon, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 12, 2024
sagemathgh-37831: `FreeModuleHomset`: Create subclass `FreeModuleEndset`, add element methods for invariants `det`, `charpoly`, `fcp`, etc. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> We create - a parent subclass `FreeModuleEndset` (of `FreeModuleHomset`) - an element subclass `FiniteRankFreeModuleEndomorphism` (of `FiniteRankFreeModuleMorphism`) for the purpose of providing specific methods of endomorphisms, namely the endomorphism invariants `det`, `trace`, `charpoly`, etc. This is parallel to what is done - for ModulesWithBasis in sagemath#37731 - in sagemath#37826 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37831 Reported by: Matthias Köppe Reviewer(s): Eric Gourgoulhon, Travis Scrimshaw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We create
FreeModuleEndset(ofFreeModuleHomset)FiniteRankFreeModuleEndomorphism(ofFiniteRankFreeModuleMorphism)for the purpose of providing specific methods of endomorphisms, namely the endomorphism invariants
det,trace,charpoly, etc.This is parallel to what is done
MatrixMorphism_abstract: Move endomorphism invariants to category #37731📝 Checklist
⌛ Dependencies