Skip to content

Comments

MatrixMorphism_abstract: Move endomorphism invariants to category#37731

Merged
vbraun merged 13 commits intosagemath:developfrom
mkoeppe:MatrixMorphism_to_category
Apr 27, 2024
Merged

MatrixMorphism_abstract: Move endomorphism invariants to category#37731
vbraun merged 13 commits intosagemath:developfrom
mkoeppe:MatrixMorphism_to_category

Conversation

@mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Apr 2, 2024 •
edited
Loading

We move the methods charpoly, det, fcp, trace from MatrixMorphism_abstract to the Homsets.Endset.ElementMethods of the category FiniteDimensionalModulesWithBasis. Likewise, we move the method minpoly there from FreeModuleMorphism.

This makes them also available to endomorphisms of CombinatorialFreeModule.

We also deprecate the functions is_MatrixMorphism, is_FreeModuleMorphism, is_VectorSpaceMorphism (as part of #32414); they were almost unused.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@tscrim
Copy link
Collaborator

tscrim commented Apr 4, 2024

There is an Endsets axiom for Homsets, so you can move those methods to that subcatregory.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 4, 2024

https://github.com/sagemath/sage/blob/develop/src/sage/categories/modules.py#L818 seems to caution that Endset "is not used yet", but I'll try if this works.

@tscrim
Copy link
Collaborator

tscrim commented Apr 6, 2024

Two trivial failures in src/sage/categories/modules_with_basis.py.

tscrim
tscrim reviewed Apr 6, 2024
View reviewed changes
src/sage/modules/free_module_morphism.py Outdated

class FreeModuleMorphism(matrix_morphism.MatrixMorphism):

minimal_polynomial = minpoly = FiniteDimensionalModulesWithBasis.Homsets.Endset.ElementMethods.minimal_polynomial
Copy link
Collaborator

@tscrim tscrim Apr 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary? Shouldn't this come from the category?

Copy link
Contributor Author

@mkoeppe mkoeppe Apr 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed it

@github-actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 84b0b23; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Matthias Koeppe added 13 commits April 17, 2024 21:25
@mkoeppe
src/sage/modules/matrix_morphism.py: Deprecate is_MatrixMorphism
b980729
@mkoeppe
MatrixMorphism_abstract.{charpoly,det,fcp,trace}: Move to category
1d76294
@mkoeppe
FiniteDimensionalModulesWithBasis.MorphismMethods.{charpoly,det,fcp,t…
a9d6761 
…race}: Add CombinatorialFreeModule examples
@mkoeppe
FiniteDimensionalModulesWithBasis.MorphismMethods: Define both det an…
cb90891 
…d determinant
@mkoeppe
FiniteDimensionalModulesWithBasis.MorphismMethods: Add methods minpol…
4dcf44d 
…y, minimal_polynomial
@mkoeppe
Remove FreeModuleMorphism.minpoly, move doctest to category method
9c1e393
@mkoeppe
MatrixMorphism_abstract, FreeModuleMorphism: Copy in methods from cat…
e9a9c06 
…egory
@mkoeppe
src/sage/modular/abvar/morphism.py (HeckeOperator): Override method f…
a40402b 
…cp to make it compatible with custom charpoly
@mkoeppe
src/sage/modules/matrix_morphism.py: Fill in PR number in deprecation
b1a0ad5
@mkoeppe
is_FreeModuleMorphism, is_VectorSpaceMorphism: Deprecate
49ed055
@mkoeppe
Move methods to FiniteDimensionalModulesWithBasis.Homsets.Endset.Elem…
5a827d8 
…entMethods
@mkoeppe
FreeModuleMorphism: Revert 'Copy in methods from category'
e965c0f
@mkoeppe
src/sage/categories/modules_with_basis.py: Update doctest output
84b0b23
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 23, 2024

Any further concerns, or can we merge it?

tscrim
tscrim approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this can be merged.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 23, 2024

Thanks!

@vbraun vbraun merged commit 9aca7a3 into sagemath:develop Apr 27, 2024
vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 28, 2024
f12c4e3 
sagemathgh-37826: FreeModuleAutomorphism: Add more invariants
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

We add more methods that complement the existing methods `det` and
`trace`, by delegating to the existing methods of Sage matrices.

This is parallel to what is done for ModulesWithBasis in:
- sagemath#37731

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37826
Reported by: Matthias Köppe
Reviewer(s): Eric Gourgoulhon, Matthias Köppe, Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request May 2, 2024
7d0a347 
sagemathgh-37826: FreeModuleAutomorphism: Add more invariants
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

We add more methods that complement the existing methods `det` and
`trace`, by delegating to the existing methods of Sage matrices.

This is parallel to what is done for ModulesWithBasis in:
- sagemath#37731

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37826
Reported by: Matthias Köppe
Reviewer(s): Eric Gourgoulhon, Matthias Köppe, Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request May 4, 2024
05100c9 
sagemathgh-37831: `FreeModuleHomset`: Create subclass `FreeModuleEndset`, add element methods for invariants `det`, `charpoly`, `fcp`, etc.
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

We create
- a parent subclass `FreeModuleEndset` (of `FreeModuleHomset`)
- an element subclass `FiniteRankFreeModuleEndomorphism` (of
`FiniteRankFreeModuleMorphism`)

for the purpose of providing specific methods of endomorphisms, namely
the endomorphism invariants `det`, `trace`, `charpoly`, etc.

This is parallel to what is done
- for ModulesWithBasis in sagemath#37731
- in sagemath#37826

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37831
Reported by: Matthias Köppe
Reviewer(s): Eric Gourgoulhon, Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request May 9, 2024
018d550 
sagemathgh-37831: `FreeModuleHomset`: Create subclass `FreeModuleEndset`, add element methods for invariants `det`, `charpoly`, `fcp`, etc.
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

We create
- a parent subclass `FreeModuleEndset` (of `FreeModuleHomset`)
- an element subclass `FiniteRankFreeModuleEndomorphism` (of
`FiniteRankFreeModuleMorphism`)

for the purpose of providing specific methods of endomorphisms, namely
the endomorphism invariants `det`, `trace`, `charpoly`, etc.

This is parallel to what is done
- for ModulesWithBasis in sagemath#37731
- in sagemath#37826

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37831
Reported by: Matthias Köppe
Reviewer(s): Eric Gourgoulhon, Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request May 11, 2024
fdc799d 
sagemathgh-37831: `FreeModuleHomset`: Create subclass `FreeModuleEndset`, add element methods for invariants `det`, `charpoly`, `fcp`, etc.
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

We create
- a parent subclass `FreeModuleEndset` (of `FreeModuleHomset`)
- an element subclass `FiniteRankFreeModuleEndomorphism` (of
`FiniteRankFreeModuleMorphism`)

for the purpose of providing specific methods of endomorphisms, namely
the endomorphism invariants `det`, `trace`, `charpoly`, etc.

This is parallel to what is done
- for ModulesWithBasis in sagemath#37731
- in sagemath#37826

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37831
Reported by: Matthias Köppe
Reviewer(s): Eric Gourgoulhon, Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request May 12, 2024
246aefe 
sagemathgh-37831: `FreeModuleHomset`: Create subclass `FreeModuleEndset`, add element methods for invariants `det`, `charpoly`, `fcp`, etc.
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

We create
- a parent subclass `FreeModuleEndset` (of `FreeModuleHomset`)
- an element subclass `FiniteRankFreeModuleEndomorphism` (of
`FiniteRankFreeModuleMorphism`)

for the purpose of providing specific methods of endomorphisms, namely
the endomorphism invariants `det`, `trace`, `charpoly`, etc.

This is parallel to what is done
- for ModulesWithBasis in sagemath#37731
- in sagemath#37826

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37831
Reported by: Matthias Köppe
Reviewer(s): Eric Gourgoulhon, Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request May 12, 2024
fd4465f 
sagemathgh-37831: `FreeModuleHomset`: Create subclass `FreeModuleEndset`, add element methods for invariants `det`, `charpoly`, `fcp`, etc.
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

We create
- a parent subclass `FreeModuleEndset` (of `FreeModuleHomset`)
- an element subclass `FiniteRankFreeModuleEndomorphism` (of
`FiniteRankFreeModuleMorphism`)

for the purpose of providing specific methods of endomorphisms, namely
the endomorphism invariants `det`, `trace`, `charpoly`, etc.

This is parallel to what is done
- for ModulesWithBasis in sagemath#37731
- in sagemath#37826

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37831
Reported by: Matthias Köppe
Reviewer(s): Eric Gourgoulhon, Travis Scrimshaw
@fchapoton fchapoton mentioned this pull request Jan 4, 2026
Merged
3 tasks
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 6, 2026
9837e72 
sagemathgh-41392: remove some deprecated stuff in modules
    
after

sagemath#37924 ; Closed Date: 2024-05-25
sagemath#33617 ; Closed Date: 2022-05-24
sagemath#37731 ; Closed Date: 2024-04-27

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
    
URL: sagemath#41392
Reported by: Frédéric Chapoton
Reviewer(s):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tscrim tscrim tscrim approved these changes

@grhkm21 grhkm21 Awaiting requested review from grhkm21

Assignees

@mkoeppe mkoeppe

Labels

c: linear algebra

Projects

None yet

Milestone

sage-10.4

Development

Successfully merging this pull request may close these issues.

3 participants

@mkoeppe @tscrim @vbraun