Removed BUG method and include a docstring for matrix_of_frobenius()#37615
Merged
vbraun merged 7 commits intosagemath:developfrom Apr 12, 2024
Merged
Conversation
Contributor
Author
|
@kwankyu maybe you'll have time to review this? One question have is why is this method defined for curves over the rationals if we explicitly change the ring anyway? Feels like maybe I should move it to generic? |
2 tasks
Contributor
|
Because only rational elements are coercable to p-adic numbers, probably. sage: x = var("x")
....: K.<a> = NumberField(x^3 + 2)
....: R.<x> = K[]
....: H = HyperellipticCurve(x^5 + a*x + 3)
....: monsky_washnitzer.matrix_of_frobenius_hyperelliptic(H.change_ring(Qp(7)))
# TypeError: Unable to coerce a to a rational |
grhkm21
suggested changes
Apr 3, 2024
src/sage/schemes/hyperelliptic_curves/hyperelliptic_rational_field.py
Outdated
Show resolved
Hide resolved
src/sage/schemes/hyperelliptic_curves/hyperelliptic_rational_field.py
Outdated
Show resolved
Hide resolved
Co-authored-by: grhkm21 <[email protected]>
Contributor
|
If CI passes then it looks good to me |
2 tasks
Contributor
Author
|
CI failure from some other unrelated bug i think |
Contributor
Contributor
Author
|
Thanks for helping with the labels and confirming about the failure. |
|
Documentation preview for this PR (built with commit 4faa6a8; changes) is ready! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reviewing code for hyperelliptic curves I found a method labeled bug with a typo in the name which was unnecessary. I have removed this method and included doctests which were previously absent.
📝 Checklist