CI macOS: Fix failure with macos-13-homebrew, add tests on M1 runners, add timeouts#37237
Merged
vbraun merged 17 commits intosagemath:developfrom Feb 29, 2024
Merged
CI macOS: Fix failure with macos-13-homebrew, add tests on M1 runners, add timeouts#37237vbraun merged 17 commits intosagemath:developfrom
vbraun merged 17 commits intosagemath:developfrom
Conversation
Contributor
|
Do you have a link to a test run? |
Contributor
Author
|
I've just started a fresh one: https://github.com/mkoeppe/sage/actions/runs/7803064164 |
Contributor
Author
tobiasdiez
suggested changes
Feb 14, 2024
| [["latest", "", "homebrew-macos-usrlocal-minimal"], | ||
| ["latest", "", "homebrew-macos-usrlocal-standard"], | ||
| ["11", "xcode_13.2.1", "homebrew-macos-usrlocal-minimal"], | ||
| [["11", "xcode_13.2.1", "homebrew-macos-usrlocal-minimal"], |
Contributor
There was a problem hiding this comment.
To keep the overall execution time constant (to not increase the priority of the portability ci runs over the PR runs even more), please remove macos-11 (it's past its end of life anyway)
Contributor
Author
There was a problem hiding this comment.
To keep the overall execution time constant
That's not a relevant criterion. These platforms are tested because we want them tested.
Contributor
There was a problem hiding this comment.
That's not a relevant criterion.
For me it's a very relevant criterion.
Contributor
Author
There was a problem hiding this comment.
I'll not be negotiating with you how I run the portability CI.
For reference: #36726 (comment), #36726 (comment)
| ["latest", "", "homebrew-macos-usrlocal-maximal"], | ||
| ["latest", "", "homebrew-macos-usrlocal-python3_xcode-standard"], | ||
| ["14", "", "homebrew-macos-opthomebrew-standard"], | ||
| ["latest", "", "conda-forge-macos-minimal"], |
Contributor
There was a problem hiding this comment.
This fails, can we disable it until someone finds the time to fix it?
Contributor
Author
There was a problem hiding this comment.
No, it's useful as a reminder what needs fixing.
Contributor
There was a problem hiding this comment.
An issue would serve that purpose better.
Contributor
Author
There was a problem hiding this comment.
Nope. Source: I'm the person who monitors the portability CI.
| id: python | ||
| with: | ||
| python-version: "3.8 - 3.12" | ||
| update-environment: false |
Contributor
There was a problem hiding this comment.
why do you set update-environment to false? Otherwise you could just use python below.
Contributor
Author
There was a problem hiding this comment.
Because i want to use this Python only for running tox, not for influencing the Sage build.
Contributor
There was a problem hiding this comment.
If it would have a preinstalled python, it would also influence the sage build.
Contributor
|
Removing blocker as there are problems with other PRs, see #37428 for more details. |
Contributor
Author
|
Restoring "blocker" -- this PR needs to go into the stable release. |
added 17 commits
February 25, 2024 09:49
Contributor
Author
|
Thanks, Volker! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 25, 2024
…ests on M1 runners, add timeouts <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> - Fixing the failure with `macos-13-homebrew`, as seen in https://github.com/sagemath/sage/actions/runs/7761817710/job/21171032513 and upstream uses of macos.yml dimpase/primecountpy#11 (comment), sagemath/cypari2#152 - Generalizing the `ld_classic` workaround from sagemath#36599 for the case of full XCode. - This is to fix the failure seen on `homebrew-macos-13-usrlocal- standard-xcode_15.0`, e.g. in https://github.com/scipopt/SCIP- SDP/actions/runs/7793548242/job/21253452882?pr=9#step:10:2766 - Deactivating the `ld_classic` workaround when `LD` is set, as is in a conda environment; as seen e.g. in https://groups.google.com/g/sage- devel/c/1viBzw-ZaoQ/m/S_u9K20xAAAJ - [Apple Silicon runners recently became available](https://github.blog/changelog/2024-01-30-github-actions- introducing-the-new-m1-macos-runner-available-to-open-source/); we add some tests (example run: https://github.com/mkoeppe/sage/actions/runs/7772086965/job/21194110510) - On Apple Silicon, `tox -e local-conda-forge` now uses the correct installer - Intel runners were recently upgraded too, increase parallelism. - Add self-destruct sequence to cancel workflows before the 6h limit (catches linbox-related build hang) - Actually handle the input `extra_sage_packages` (for scipopt/PySCIPOpt#630) <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> Follow-ups, not addressed here: - conda-forge-macos-latest-minimal tachyon build failure - needs sagemath#36969 - adding a config that tests arm64 conda-forge-minimal - would need config.guess updates in numerous packages - arm64 conda-forge-standard - matplotlib build failure (https://github. com/mkoeppe/sage/actions/runs/7810111886/job/21313997438#step:10:2749) - hangs or excessive build time that lead to timeouts, probably from linbox ### :memo: Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### :hourglass: Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37237 Reported by: Matthias Köppe Reviewer(s): Matthias Köppe, Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 26, 2024
sagemathgh-37237: CI macOS: Fix failure with macos-13-homebrew, add tests on M1 runners, add timeouts <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> - Fixing the failure with `macos-13-homebrew`, as seen in https://github.com/sagemath/sage/actions/runs/7761817710/job/21171032513 and upstream uses of macos.yml dimpase/primecountpy#11 (comment), sagemath/cypari2#152 - Generalizing the `ld_classic` workaround from sagemath#36599 for the case of full XCode. - This is to fix the failure seen on `homebrew-macos-13-usrlocal- standard-xcode_15.0`, e.g. in https://github.com/scipopt/SCIP- SDP/actions/runs/7793548242/job/21253452882?pr=9#step:10:2766 - Deactivating the `ld_classic` workaround when `LD` is set, as is in a conda environment; as seen e.g. in https://groups.google.com/g/sage- devel/c/1viBzw-ZaoQ/m/S_u9K20xAAAJ - [Apple Silicon runners recently became available](https://github.blog/changelog/2024-01-30-github-actions- introducing-the-new-m1-macos-runner-available-to-open-source/); we add some tests (example run: https://github.com/mkoeppe/sage/actions/runs/7772086965/job/21194110510) - On Apple Silicon, `tox -e local-conda-forge` now uses the correct installer - Intel runners were recently upgraded too, increase parallelism. - Add self-destruct sequence to cancel workflows before the 6h limit (catches linbox-related build hang) - Actually handle the input `extra_sage_packages` (for scipopt/PySCIPOpt#630) <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> Follow-ups, not addressed here: - conda-forge-macos-latest-minimal tachyon build failure - needs sagemath#36969 - adding a config that tests arm64 conda-forge-minimal - would need config.guess updates in numerous packages - arm64 conda-forge-standard - matplotlib build failure (https://github. com/mkoeppe/sage/actions/runs/7810111886/job/21313997438#step:10:2749) - hangs or excessive build time that lead to timeouts, probably from linbox ### :memo: Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### :hourglass: Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37237 Reported by: Matthias Köppe Reviewer(s): Matthias Köppe, Tobias Diez
|
Documentation preview for this PR (built with commit 2165bef; changes) is ready! 🎉 |
hannes14
pushed a commit
to Singular/Singular
that referenced
this pull request
Mar 8, 2024
…OS arm64 testing) (#1205) * doc/singular.doc: sagbiNormaliz.lib needs tag:normaliz * doc/Makefile-docbuild.in: Remove overquoting of PATH * .github/workflows/ci-sage.yml: Add info to singular dependencies * .github/workflows/ci-sage.yml: Shorten workflow name * .github/workflows/ci-sage.yml: Use sagemath/sage#37237 for macOS tests * .github/workflows/ci-sage.yml: Build singular with V=1, timeout=3000 * .github/workflows/ci-sage.yml: Build with longer timeout for the -gcc_spkg platform * doc/doc2tex.pl [GITHUB_ACTIONS]: Print failing .res file * .github/workflows/ci-sage.yml: Set GITHUB_ACTIONS=1 * .github/workflows/ci-sage.yml: Make system readline available
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 25, 2024
sagemathgh-37494: `build/pkgs`: Update scip to 9, scip_sdp to 4.4, soplex to 7, papilo to 2.2, pyscipopt to 5, onetbb to 2021.11 <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> https://www.scipopt.org/doc-9.0.0/html/RN90.php - [x] scipopt/SCIP-SDP#12 - [ ] scipopt/soplex#35 - [x] needs pyscipopt update ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - Depends on sagemath#37237 - Depends on sagemath#37351 - Depends on sagemath#36970 - Depends on sagemath#37392 URL: sagemath#37494 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macos-13-homebrew, as seen in https://github.com/sagemath/sage/actions/runs/7761817710/job/21171032513 and upstream uses of macos.yml Remove Cython from install_requires dimpase/primecountpy#11 (comment), drop macos 13 failing check cypari2#152ld_classicworkaround from sage-env: identify the version of command-line tools (OS X) and set LDFLAGS accordingly #36599 for the case of full XCode.homebrew-macos-13-usrlocal-standard-xcode_15.0, e.g. in https://github.com/scipopt/SCIP-SDP/actions/runs/7793548242/job/21253452882?pr=9#step:10:2766ld_classicworkaround whenLDis set, as is in a conda environment; as seen e.g. in https://groups.google.com/g/sage-devel/c/1viBzw-ZaoQ/m/S_u9K20xAAAJtox -e local-conda-forgenow uses the correct installerextra_sage_packages(for CI: Portability tests for building on various Linux distributions and macOS scipopt/PySCIPOpt#630)Follow-ups, not addressed here:
build/pkgs/tachyon: Upgrade to 0.99.5 #36969📝 Checklist
⌛ Dependencies