Skip to content

Comments

build/pkgs/flint 3.1.3#37203

Merged
vbraun merged 30 commits intosagemath:developfrom
mkoeppe:gmp_require_6_2_1
May 25, 2024
Merged

build/pkgs/flint 3.1.3#37203
vbraun merged 30 commits intosagemath:developfrom
mkoeppe:gmp_require_6_2_1

Conversation

@mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jan 31, 2024 •
edited
Loading

For this upgrade we tighten the check for GMP so that 6.2.1 is accepted but 6.2.0 is rejected. For example ubuntu-focal-standard brings 6.2.0, we accept it, and then FLINT complains:
https://github.com/mkoeppe/flint2/actions/runs/7718792281/job/21040793706#step:11:5395

We also change the upper bound on system flint accepted by configure. Closes #37838.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 26, 2024

The tests haven't run yet, but apparently we need a patch for FLINT 3.1.0 support? https://groups.google.com/g/sage-support/c/72w_C1O6lPs/m/QC6M0CtVEAAJ @antonio-rojas

@antonio-rojas
Copy link
Contributor

antonio-rojas commented Feb 26, 2024

The tests haven't run yet, but apparently we need a patch for FLINT 3.1.0 support? https://groups.google.com/g/sage-support/c/72w_C1O6lPs/m/QC6M0CtVEAAJ @antonio-rojas

Yes, I will submit a PR in a few hours

@antonio-rojas
Copy link
Contributor

antonio-rojas commented Feb 26, 2024

Note that singular also needs patching (my PR will only handle sagelib)

https://gitlab.archlinux.org/archlinux/packaging/packages/singular/-/blob/main/flint-3.1.patch?ref_type=heads

@antonio-rojas
Copy link
Contributor

antonio-rojas commented Feb 26, 2024

The tests haven't run yet, but apparently we need a patch for FLINT 3.1.0 support? https://groups.google.com/g/sage-support/c/72w_C1O6lPs/m/QC6M0CtVEAAJ @antonio-rojas

Yes, I will submit a PR in a few hours

#37484

vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 2, 2024
9074121 
sagemathgh-37495: build/pkgs/flint: Reject FLINT >= 3.1.0
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Because our Singular does not support it yet, see sagemath#37203


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37495
Reported by: Matthias Köppe
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 4, 2024
fc0d339 
sagemathgh-37495: build/pkgs/flint: Reject FLINT >= 3.1.0
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Because our Singular does not support it yet, see sagemath#37203


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37495
Reported by: Matthias Köppe
Reviewer(s):
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 11, 2024

The incremental build (Build&Test) shows:

ImportError: libflint.so.18: cannot open shared object file: No such file or directory

(https://github.com/sagemath/sage/actions/runs/8626409427/job/23644543324?pr=37203#step:14:54)

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 24, 2024

Full tests ran at https://github.com/mkoeppe/sage/actions/runs/8761823524

faisalfakhro and others added 22 commits April 25, 2024 17:30
@faisalfakhro
add sha256
d879f03
@faisalfakhro
sha256/sha1 checksum priority
b45ada6
@faisalfakhro
update checksums.ini files with sha256
bde1df4
@faisalfakhro
remove md5, cksum
d890bd9
@mkoeppe @faisalfakhro
build/pkgs/symengine_py/checksums.ini: Fix upstream_url
65f1f01
@mkoeppe @faisalfakhro
sage_bootstrap.tarball: After checking sha256, also check sha1 for co…
685b4dc 
…nsistency
@mkoeppe @faisalfakhro
sage -package fix-checksum: If sha256 is not available, create it
d75ca34
@mkoeppe @faisalfakhro
Update checksums.ini for updated packages
626539b
@faisalfakhro
update packages checksums.ini
a3ccd8d
@faisalfakhro
Merge branch 'develop' into update_hashes
091aa47
@mkoeppe
Merge branch 'pip-24' into update_hashes
03bfd92
@mkoeppe
Merge branch 'gambit_remove' into update_hashes
0fe263a
@mkoeppe
sage -package fix-checksum :all:
4044324
@mkoeppe
Merge remote-tracking branch 'upstream/develop' into update_hashes
f2f63e9
@mkoeppe
build/pkgs/{editables,fricas}: Add sha256
d831891
@mkoeppe
Merge branch 'singular-4.3.2p16' into update_hashes
7587edf
@mkoeppe
Merge branch 'update-libgc-8_2_6' into update_hashes
840eea0
@mkoeppe
build/pkgs/{gc,singular}: Add sha256
72b755a
@mkoeppe
Merge branch 'culler/develop' into update_hashes
d955e50
@mkoeppe
build/pkgs/python3: Add sha256
8b0768a
@mkoeppe
Merge remote-tracking branch 'upstream/develop' into update_hashes
1578923
@mkoeppe
sage -package fix-checksum :all:
eb08315
kwankyu
kwankyu reviewed May 20, 2024
View reviewed changes
kwankyu
kwankyu reviewed May 20, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented May 20, 2024

Documentation preview for this PR (built with commit e2d2df4; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kwankyu
Copy link
Collaborator

kwankyu commented May 21, 2024

There is also a merge conflict with #38025.

kwankyu
kwankyu approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 21, 2024

Thanks!

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 21, 2024

There is also a merge conflict with #38025.

I've already merged #37726 into that PR; you may need to pull

@vbraun vbraun merged commit 4a6edc3 into sagemath:develop May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kwankyu kwankyu kwankyu approved these changes

@antonio-rojas antonio-rojas Awaiting requested review from antonio-rojas

Assignees

@mkoeppe mkoeppe

Labels

c: packages: standard v: large

Projects

None yet

Milestone

sage-10.4

Development

Successfully merging this pull request may close these issues.

restricting Flint version should be conditional on installing Singular

5 participants

@mkoeppe @antonio-rojas @kwankyu @vbraun @faisalfakhro