`configure.ac`: Remove tests for outdated platforms by mkoeppe · Pull Request #36915 · sagemath/sage

mkoeppe · 2023-12-18T18:45:19Z

Likewise for some configuration tests in some spkg-configure.m4 and spkg-install scripts.

Cygwin, AIX, Solaris, ancient OS X, etc.

📝 Checklist

The title is concise, informative, and self-explanatory.
The description explains in detail what this PR is about.
I have linked a relevant issue or discussion.
I have created tests covering the changes.
I have updated the documentation accordingly.

⌛ Dependencies

kwankyu · 2024-01-05T02:33:53Z

What is an outdated platform? If a platform does not run an OS in the list of our release tour, is that outdated?

mkoeppe · 2024-01-05T02:35:52Z

Yes. Basically everything except for Linux and macOS.

mkoeppe · 2024-01-05T02:41:19Z

... also removed here:

Tests/workarounds for ancient compilers such as GCC 4.x
32-bit macOS

build/pkgs/gmp/spkg-install.in

build/pkgs/openblas/spkg-configure.m4

build/pkgs/r/spkg-configure.m4

kwankyu · 2024-01-05T08:17:02Z

Otherwise lgtm.

dimpase · 2024-01-05T10:11:53Z

configure.ac

-may not work. If you would like to help port Sage to $host,
-please join the sage-devel discussion list - see
-http://groups.google.com/group/sage-devel
-The Sage community would also appreciate any patches you submit]]);;


I'd have left these lines 214/8 in. It doesn't harm.

Do you understand that it is for example inviting people who try to build it on Cygwin to help us port it to Cygwin?

In 2024, I don't think anyone in their right mind would try porting anything to Cygwin

See, that's why I'm removing this line here. It's a milder solution than including the warning "If you dare to even mention your unsupported platform, a certain senior developer will unleash uncontrolled abuse on you."

Are you going to remove all the "you welcome to contribute" everywhere in the docs too?

Your favourite, and supported, platform, macOS, is a pile of merde, pardon my French.

Just by the way.

kwankyu · 2024-01-07T19:40:00Z

Would you rebase to develop? I think CI does not do that.

mkoeppe · 2024-01-07T19:42:18Z

Rebased

kwankyu

Thanks.

mkoeppe · 2024-01-08T02:29:35Z

Thank you!

vbraun · 2024-01-12T02:40:49Z

I'm getting (but only after a make distclean)

sage -t --long --warn-long 39.6 --random-seed=123 src/sage/rings/complex_double.pyx
**********************************************************************
File "src/sage/rings/complex_double.pyx", line 2290, in sage.rings.complex_double.ComplexDoubleElement.agm
Failed example:
    a.agm(b, algorithm='principal')  # rel tol 1e-15
Expected:
    0.33817546298618006 - 0.013532696956540503*I
Got:
    0.33817546298618006 - 0.013532696956540465*I
Tolerance exceeded in 1 of 2:
    - 0.013532696956540503 vs - 0.013532696956540465, tolerance 3e-15 > 1e-15
**********************************************************************

mkoeppe · 2024-01-12T02:58:58Z

Which system

vbraun · 2024-01-12T17:52:59Z

Fedora x86_64

mkoeppe · 2024-01-12T18:44:57Z

Seems highly unlikely to me it's coming from this PR. I'll wait for the next beta.

vbraun · 2024-01-13T01:44:20Z

I spent quite a lot of time make distcleaning until tracking this down.

My guess its from the openblas changes 🤷

kwankyu · 2024-01-30T13:21:21Z

The doctest passes for me (on Fedora x86_64).

vbraun · 2024-01-31T23:32:09Z

Still happens, its 100% reproducable for me

mkoeppe · 2024-01-31T23:33:32Z

Then we need details such as build logs etc. from your mystery machine, before–after

vbraun · 2024-01-31T23:37:36Z

Fedora 39, kernel 6.6.11-200.fc39.x86_64, Ryzen 7 5800X

Its pretty clear that its just a case of numerical noise, how about upping the tolerance?

mkoeppe · 2024-01-31T23:40:21Z

config.log please?

mkoeppe · 2024-01-31T23:41:43Z

I can also open a subset PR to bisect this if that's easier

vbraun · 2024-01-31T23:47:33Z

config.log.36915.before.txt
config.log.36915.after.txt

The diff contains

 CDDEXECGMP=''
-CFLAGS='-g -O2'
+CFLAGS=''
 CFLAGS_MARCH='-march=native'

mkoeppe · 2024-01-31T23:49:00Z

OK, thanks. I'll investigate.

mkoeppe · 2024-02-01T03:02:08Z

Apparently caused by 9ea8982

mkoeppe · 2024-02-01T03:05:37Z

Doing this:

diff --git a/configure.ac b/configure.ac
index a24562ea1a7..65937a73cf2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -344,12 +344,6 @@ AX_PROG_PERL_VERSION([5.8.0],[],[
 # Check C/C++/Fortran compilers
 ###############################################################################
 
-# Save compiler flags as configured by the user.
-# We have to redo this, because otherwise `AC_PROG_CC` will just overwrite them.
-AC_SUBST(CFLAGS, "$CFLAGS")
-AC_SUBST(CXXFLAGS, "$CXXFLAGS")
-AC_SUBST(FCFLAGS, "$FCFLAGS")
-AC_SUBST(F77FLAGS, "$F77FLAGS")
 AC_ARG_VAR(CFLAGS, C compiler flags)
 AC_ARG_VAR(CXXFLAGS, C compiler flags)
 AC_ARG_VAR(FCFLAGS, Fortran compiler flags)

repairs the CFLAGS, but this is part of the "march=native" stuff, which I don't want to touch right now.

So I'll just drop commit 9ea8982 here.

…in texlive/spkg-configure.m4)

…platforms; do not invite users to port to random unsupported platforms

…es for prehistoric OS X versions

…re.ac -w --date=format:%Y | sort -k2'

…code

…ort code

…pace

github-actions · 2024-02-01T03:40:54Z

Documentation preview for this PR (built with commit e0548a0; changes) is ready! 🎉

sagemathgh-36915: `configure.ac`: Remove tests for outdated platforms   Likewise for some configuration tests in some `spkg-configure.m4` and `spkg-install` scripts. Cygwin, AIX, Solaris, ancient OS X, etc.    ### 📝 Checklist     - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies   URL: sagemath#36915 Reported by: Matthias Köppe Reviewer(s): Dima Pasechnik, Kwankyu Lee, Matthias Köppe

kwankyu reviewed Jan 5, 2024

View reviewed changes

build/pkgs/gmp/spkg-install.in Show resolved Hide resolved

kwankyu reviewed Jan 5, 2024

View reviewed changes

build/pkgs/openblas/spkg-configure.m4 Outdated Show resolved Hide resolved

kwankyu reviewed Jan 5, 2024

View reviewed changes

build/pkgs/r/spkg-configure.m4 Outdated Show resolved Hide resolved

dimpase reviewed Jan 5, 2024

View reviewed changes

dimpase added s: needs work and removed s: needs review labels Jan 5, 2024

kwankyu approved these changes Jan 8, 2024

View reviewed changes

kwankyu added s: positive review and removed s: needs review labels Jan 8, 2024

vbraun added the s: needs work label Jan 12, 2024

kwankyu added s: positive review and removed s: needs review labels Jan 30, 2024

kwankyu mentioned this pull request Jan 31, 2024

Various edits of developer guide #37206

Merged

5 tasks

vbraun added the s: needs work label Jan 31, 2024

Matthias Koeppe added 16 commits January 31, 2024 19:06

configure.ac: Remove outdated comments

5f50f16

configure.ac: Remove redundant check for latex (we check it properly …

3694e1d

…in texlive/spkg-configure.m4)

configure.ac: Remove specific error messages for ancient unsupported …

b2782cc

…platforms; do not invite users to port to random unsupported platforms

configure.ac: Remove AIX-specific message

072b009

configure.ac, m4/sage_check_osx_supported.m4: Remove tests and messag…

2e17227

…es for prehistoric OS X versions

configure.ac: Update copyright, according to 'git blame -M -C configu…

7235741

…re.ac -w --date=format:%Y | sort -k2'

build/pkgs/gmp/spkg-install.in: Remove code for outdated platforms

5ec54b7

build/bin/testcxx.sh: Unused, remove

49b7ebe

build/pkgs/m4ri*/spkg-install.in: Remove use of testcc.sh, testcflags.sh

65e60ee

build/pkgs/python3/spkg-build.in: Remove code for SunOS

5086ba9

build/bin/testcc.sh: Unused, remove

5384ddc

build/pkgs/gmp/spkg-install.in: Remove outdated OS X / clang support …

ada1aac

…code

build/pkgs/{lie,rubiks}/spkg-install.in: Remove SunOS support code

f9d8e7b

build/pkgs/{openblas,openssl,r}/spkg-configure.m4: Remove Cygwin supp…

1af9469

…ort code

build/pkgs/openblas/spkg-configure.m4: Reindent, suppress some whites…

b2268fb

…pace

build/pkgs/r/spkg-configure.m4: Reindent, suppress some whitespace

e0548a0

vbraun removed the s: needs work label Feb 2, 2024

vbraun merged commit 3942b62 into sagemath:develop Feb 13, 2024

github-actions bot removed the s: positive review label Feb 14, 2024

Uh oh!

Comments

Conversation

mkoeppe commented Dec 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Checklist

⌛ Dependencies

Uh oh!

kwankyu commented Jan 5, 2024

Uh oh!

mkoeppe commented Jan 5, 2024

Uh oh!

mkoeppe commented Jan 5, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kwankyu commented Jan 5, 2024

Uh oh!

dimpase Jan 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkoeppe Jan 5, 2024

Choose a reason for hiding this comment

Uh oh!

dimpase Jan 5, 2024

Choose a reason for hiding this comment

Uh oh!

mkoeppe Jan 5, 2024

Choose a reason for hiding this comment

Uh oh!

dimpase Jan 5, 2024

Choose a reason for hiding this comment

Uh oh!

dimpase Jan 5, 2024

Choose a reason for hiding this comment

Uh oh!

kwankyu commented Jan 7, 2024

Uh oh!

mkoeppe commented Jan 7, 2024

Uh oh!

kwankyu left a comment

Choose a reason for hiding this comment

Uh oh!

mkoeppe commented Jan 8, 2024

Uh oh!

vbraun commented Jan 12, 2024

Uh oh!

mkoeppe commented Jan 12, 2024

Uh oh!

vbraun commented Jan 12, 2024

Uh oh!

mkoeppe commented Jan 12, 2024

Uh oh!

vbraun commented Jan 13, 2024

Uh oh!

kwankyu commented Jan 30, 2024

Uh oh!

vbraun commented Jan 31, 2024

Uh oh!

mkoeppe commented Jan 31, 2024

Uh oh!

vbraun commented Jan 31, 2024

Uh oh!

mkoeppe commented Jan 31, 2024

Uh oh!

mkoeppe commented Jan 31, 2024

Uh oh!

vbraun commented Jan 31, 2024

Uh oh!

mkoeppe commented Jan 31, 2024

Uh oh!

mkoeppe commented Feb 1, 2024

Uh oh!

mkoeppe commented Feb 1, 2024

Uh oh!

github-actions bot commented Feb 1, 2024

Uh oh!

Reviewers

mkoeppe commented Dec 18, 2023 •

edited

Loading

dimpase Jan 5, 2024 •

edited

Loading