Fix build of optional Cython modules broken in #29386#36900
Merged
vbraun merged 1 commit intosagemath:developfrom Dec 19, 2023
Merged
Fix build of optional Cython modules broken in #29386#36900vbraun merged 1 commit intosagemath:developfrom
vbraun merged 1 commit intosagemath:developfrom
Conversation
…with SAGE_SPKG_INST set by sage-spkg
|
Documentation preview for this PR (built with commit 3350f7f; changes) is ready! 🎉 |
Contributor
Author
|
Thanks. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cython modules depending on optional packages (such as sage.libs.coxeter3) were not being built after #29386. This showed up in the CI as numerous doctest failures; as reported in #36775 (comment)
Fixed here by avoiding a clash of environment variables that prevented the function
is_package_installed_and_updatedfrom functioning during the build of sagelib.📝 Checklist
⌛ Dependencies