sage.groups, sage.rings.number_field: Modularization fixes, # needs#36865
Merged
vbraun merged 23 commits intosagemath:developfrom Dec 19, 2023
Merged
sage.groups, sage.rings.number_field: Modularization fixes, # needs#36865vbraun merged 23 commits intosagemath:developfrom
sage.groups, sage.rings.number_field: Modularization fixes, # needs#36865vbraun merged 23 commits intosagemath:developfrom
Conversation
dcoudert
reviewed
Dec 13, 2023
Contributor
dcoudert
left a comment
There was a problem hiding this comment.
Don't you need to list the new file galois_group_perm.py in the right .rst file so that it appear in https://doc.sagemath.org/html/en/reference/groups/index.html ?
otherwise, LGTM.
Contributor
Author
|
Also |
dcoudert
approved these changes
Dec 13, 2023
Contributor
dcoudert
left a comment
There was a problem hiding this comment.
LGTM.
The addition to the appropriate place in some index.rst file can be done later.
Contributor
Author
|
Thank you! |
added 23 commits
December 13, 2023 17:14
Contributor
Author
|
rebased |
|
Documentation preview for this PR (built with commit 1d77a49; changes) is ready! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard modularization work:
sage.libs.braiding# needsto simplify decorations# needs, in particular forsage.libs.gapsage.groups.galois_grouplazy_importsPart of:
📝 Checklist
⌛ Dependencies