Skip to content

Comments

Remove cygwin.txt#36782

Closed
mkoeppe wants to merge 2 commits intosagemath:developfrom
mkoeppe:remove_cygwin_txt
Closed

Remove cygwin.txt#36782
mkoeppe wants to merge 2 commits intosagemath:developfrom
mkoeppe:remove_cygwin_txt

Conversation

@mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Nov 26, 2023

Split out from #36778

See #36778 (comment)

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

Documentation preview for this PR (built with commit 8cee631; changes) is ready! 🎉

@dimpase
Copy link
Member

dimpase commented Nov 28, 2023

Please explain the purpose of putting this on hold. You said something about "other projects benefitting". They can just as well be using a branch where the Cygwin is still present.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 28, 2023

Dima, such calls to "go play on your own branch", like your previous suggestion that I "just fork Sage" (#35403 (comment)), are most unwelcome.

https://github.com/sagemath/sage/blob/develop/CODE_OF_CONDUCT.md

@dimpase

This comment was marked as abuse.

@dimpase dimpase mentioned this pull request Dec 22, 2023
5 tasks
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 22, 2023

without an explanation

As you well know, I explained it in the original discussion.
The link to it is in the PR description.

@dimpase dimpase added disputed PR is waiting for community vote, see https://groups.google.com/g/sage-devel/c/IgBYUJl33SQ s: needs info labels Dec 22, 2023
@vbraun
Copy link
Member

vbraun commented Feb 17, 2024

#36778 was merged, can this ticket be closed?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 17, 2024

The cygwin.txt files were not removed in the merged version of #36778. I split that proposed change out from there to this PR because I did not agree with removing them at the time. (I still do not support it because, as I explained, the information system is still useful when I help other projects with my Cygwin expertise.)

From my side, no action is needed here. It's fine with me to either close it, or to leave it as "pending" indefinitely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: build disputed PR is waiting for community vote, see https://groups.google.com/g/sage-devel/c/IgBYUJl33SQ pending

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants