Skip to content

Comments

gmp 6.3.0, mpc 1.3.1, mpfr 4.2.1, mpfrcx 0.6.3#36775

Closed
mkoeppe wants to merge 4 commits intosagemath:developfrom
mkoeppe:gmp_iml_mpfi_mpfr_mpfrcx
Closed

gmp 6.3.0, mpc 1.3.1, mpfr 4.2.1, mpfrcx 0.6.3#36775
mkoeppe wants to merge 4 commits intosagemath:developfrom
mkoeppe:gmp_iml_mpfi_mpfr_mpfrcx

Conversation

@mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Nov 26, 2023

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 26, 2023 

  [gmp-6.3.0]   OSError: [Errno socket error] [Errno 110] Connection timed out
  [gmp-6.3.0]   
  [gmp-6.3.0]   During handling of the above exception, another exception occurred:
  [gmp-6.3.0]   
  [gmp-6.3.0]   Traceback (most recent call last):
  [gmp-6.3.0]     File "/sage/build/bin/../sage_bootstrap/download/cmdline.py", line 126, in run_safe
  [gmp-6.3.0]       run()
  [gmp-6.3.0]     File "/sage/build/bin/../sage_bootstrap/download/cmdline.py", line 108, in run
  [gmp-6.3.0]       app.download_tarball(args.url_or_tarball, args.destination, args.allow_upstream)
  [gmp-6.3.0]     File "/sage/build/bin/../sage_bootstrap/download/app.py", line 41, in download_tarball
  [gmp-6.3.0]       tarball.download(allow_upstream=allow_upstream)
  [gmp-6.3.0]     File "/sage/build/bin/../sage_bootstrap/tarball.py", line 180, in download
  [gmp-6.3.0]       raise FileNotMirroredError('tarball does not exist on mirror network and neither at the upstream URL')
  [gmp-6.3.0]   sage_bootstrap.tarball.FileNotMirroredError: tarball does not exist on mirror network and neither at the upstream URL
  [gmp-6.3.0]   ************************************************************************
  [gmp-6.3.0]   ************************************************************************
  [gmp-6.3.0]   Error downloading gmp-6.3.0.tar.xz
  [gmp-6.3.0]   ************************************************************************

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 13, 2023

Because of the active countermeasures of gmplib.org, I've added the tarball as a release asset to https://github.com/sagemath/sage/releases/tag/10.2

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 14, 2023

rebased

@dimpase
Copy link
Member

dimpase commented Dec 14, 2023

Because of the active countermeasures of gmplib.org, I've added the tarball as a release asset to https://github.com/sagemath/sage/releases/tag/10.2

so there is now a place tarballs are looked for? Any rules for that (i.e. are tags ignored) ?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 14, 2023

see https://github.com/sagemath/sage/blob/develop/.upstream.d/20-github.com-sagemath-sage-releases

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 14, 2023

(You reviewed #36435, which added this.)

@dimpase
Copy link
Member

dimpase commented Dec 16, 2023

ModuleNotFoundError: No module named 'sage.libs.coxeter3.coxeter' in Test all files

and quite a few failing tests due to it

is this a known error by now? I saw it elsewhere.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 16, 2023

ModuleNotFoundError: No module named 'sage.libs.coxeter3.coxeter' in Test all files

and quite a few failing tests due to it

Fixed in #36900

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 17, 2023
sagemathgh-36900: Fix build of optional Cython modules broken in sage…
73e52a4 
…math#29386

The Cython modules depending on optional packages (such as
sage.libs.coxeter3) were not being built after sagemath#29386. This showed up in
the CI as numerous doctest failures; as reported in
sagemath#36775 (comment)

Fixed here by avoiding a clash of environment variables that prevented
the function `is_package_installed_and_updated` from functioning during
the build of sagelib.

<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

URL: sagemath#36900
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik
dimpase
dimpase approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 17, 2023

Thanks.

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 21, 2023
6091724 
sagemathgh-36351: build/pkgs/gmpy2: Update to 2.2.0a1
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
The unreleased 2.2.x series has work on support for Python 3.12

https://github.com/aleaxit/gmpy

The new version makes it necessary to tighten the requirements for MPC
and MPFR.
We do the version check without pkg-config as before; changing it to
pkg-config is sagemath#31348.


<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- Depends on sagemath#36775 (merged here)

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36351
Reported by: Matthias Köppe
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 21, 2023
a4a85b8 
sagemathgh-36775: `gmp` 6.3.0, `mpc` 1.3.1, `mpfr` 4.2.1, `mpfrcx` 0.6.3
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [ ] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36775
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 22, 2023
0e15e34 
sagemathgh-36775: `gmp` 6.3.0, `mpc` 1.3.1, `mpfr` 4.2.1, `mpfrcx` 0.6.3
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [ ] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36775
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 23, 2023
c6d0b33 
sagemathgh-36775: `gmp` 6.3.0, `mpc` 1.3.1, `mpfr` 4.2.1, `mpfrcx` 0.6.3
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [ ] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36775
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik
@vbraun
Copy link
Member

vbraun commented Dec 24, 2023

I'm getting lots of testsuite fails on OSX around signs of NaN from the gmpy2 testsuite

[gmpy2-2.1.2] **********************************************************************
[gmpy2-2.1.2] File "/Users/buildbot-sage/worker/sage_git/build/local/var/lib/sage/venv-python3.11.1/var/tmp/sage/build/gmpy2-2.1.2/src/test/test_mpz.txt", line 515, in test_mpz.txt
[gmpy2-2.1.2] Failed example:
[gmpy2-2.1.2]     divmod(mpfr('nan'), a)
[gmpy2-2.1.2] Differences (ndiff with -expected +actual):
[gmpy2-2.1.2]     - (mpfr('nan'), mpfr('nan'))
[gmpy2-2.1.2]     + (mpfr('-nan'), mpfr('-nan'))
[gmpy2-2.1.2]     ?        +             +
[gmpy2-2.1.2] **********************************************************************
[gmpy2-2.1.2] File "/Users/buildbot-sage/worker/sage_git/build/local/var/lib/sage/venv-python3.11.1/var/tmp/sage/build/gmpy2-2.1.2/src/test/test_mpz.txt", line 519, in test_mpz.txt
[gmpy2-2.1.2] Failed example:
[gmpy2-2.1.2]     divmod(mpfr('Inf'), G.mpz(0))
[gmpy2-2.1.2] Differences (ndiff with -expected +actual):
[gmpy2-2.1.2]     - (mpfr('nan'), mpfr('nan'))
[gmpy2-2.1.2]     + (mpfr('nan'), mpfr('-nan'))
[gmpy2-2.1.2]     ?                     +
[gmpy2-2.1.2] **********************************************************************
[gmpy2-2.1.2] File "/Users/buildbot-sage/worker/sage_git/build/local/var/lib/sage/venv-python3.11.1/var/tmp/sage/build/gmpy2-2.1.2/src/test/test_mpz.txt", line 523, in test_mpz.txt
[gmpy2-2.1.2] Failed example:
[gmpy2-2.1.2]     divmod(mpfr('nan'), G.mpz(0))
[gmpy2-2.1.2] Differences (ndiff with -expected +actual):
[gmpy2-2.1.2]     - (mpfr('nan'), mpfr('nan'))
[gmpy2-2.1.2]     + (mpfr('-nan'), mpfr('-nan'))
[gmpy2-2.1.2]     ?        +             +
[gmpy2-2.1.2] **********************************************************************
[gmpy2-2.1.2] 1 items had failures:
[gmpy2-2.1.2]   25 of 230 in test_mpz.txt
[gmpy2-2.1.2] ***Test Failed*** 25 failures.
[gmpy2-2.1.2] Results for:  test_mpz                  Attempted:  230   Failed:   25
[gmpy2-2.1.2] Results for:  test_mpz_create           Attempted:   58   Failed:    0
[gmpy2-2.1.2] Results for:  test_mpz_io               Attempted:   60   Failed:    0
[gmpy2-2.1.2] Results for:  test_mpz_pack_unpack      Attempted:   16   Failed:    0
[gmpy2-2.1.2] 
[gmpy2-2.1.2]                               Summary - Attempted: 3556   Failed:   95
[gmpy2-2.1.2] 
[gmpy2-2.1.2] Running external test programs.
[gmpy2-2.1.2] Running test_pack.py                    successful
[gmpy2-2.1.2] Running test_mpz_args.py                successful
[gmpy2-2.1.2] 
[gmpy2-2.1.2] real	0m1.418s
[gmpy2-2.1.2] user	0m1.349s
[gmpy2-2.1.2] sys	0m0.049s
[gmpy2-2.1.2] ************************************************************************
[gmpy2-2.1.2] Error testing package gmpy2-2.1.2
[gmpy2-2.1.2] ************************************************************************

@github-actions
Copy link

github-actions bot commented Dec 26, 2023

Documentation preview for this PR (built with commit cd3ac16; changes) is ready! 🎉

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 31, 2023

I see these test failures in the gmpy2 tests also when just using the homebrew packages (same versions), which our configure scripts already accepts

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 31, 2023 •
edited
Loading

I'll close this PR in favor of doing these upgrades as part of:

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 5, 2024
38885a6 
sagemathgh-36351: `gmp` 6.3.0, `mpc` 1.3.1, `mpfr` 4.2.1, `mpfrcx` 0.6.3, `gmpy2` 2.2.0a1
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
The unreleased 2.2.x series has work on support for Python 3.12

https://github.com/aleaxit/gmpy

The new version makes it necessary to tighten the requirements for MPC
and MPFR.
We do the version check without pkg-config as before; changing it to
pkg-config is sagemath#31348.

(The upgrade of the packages was previously done in sagemath#36775, but has now
been merged here.)

<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36351
Reported by: Matthias Köppe
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 13, 2024
729f03f 
sagemathgh-36351: `gmp` 6.3.0, `mpc` 1.3.1, `mpfr` 4.2.1, `mpfrcx` 0.6.3, `gmpy2` 2.2.0a1
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
The unreleased 2.2.x series has work on support for Python 3.12

https://github.com/aleaxit/gmpy

The new version makes it necessary to tighten the requirements for MPC
and MPFR.
We do the version check without pkg-config as before; changing it to
pkg-config is sagemath#31348.

(The upgrade of the packages was previously done in sagemath#36775, but has now
been merged here.)

<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36351
Reported by: Matthias Köppe
Reviewer(s):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dimpase dimpase dimpase approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mkoeppe mkoeppe

Labels

c: packages: standard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mkoeppe @dimpase @vbraun