CI Linux: Fixes for tests of optional packages#36708
Merged
vbraun merged 4 commits intosagemath:developfrom Nov 14, 2023
Merged
CI Linux: Fixes for tests of optional packages#36708vbraun merged 4 commits intosagemath:developfrom
vbraun merged 4 commits intosagemath:developfrom
Conversation
added 4 commits
November 12, 2023 13:35
…thon packages declared as sagelib's install-requires
… packages starting with _
…s sagelib's install-requires
|
Documentation preview for this PR (built with commit 9a82e56; changes) is ready! 🎉 |
dimpase
approved these changes
Nov 13, 2023
Member
dimpase
left a comment
dimpase
left a comment
There was a problem hiding this comment.
LGTM. Tests running locally with tox pass.
Contributor
Author
|
Thanks! Setting to blocker so that the corrected dependencies take effect in the CI. |
soehms
approved these changes
Nov 13, 2023
Member
soehms
left a comment
soehms
left a comment
There was a problem hiding this comment.
Thanks for fixing this! I just noticed a cosmetic issue: sympy is doubled in the dependencies_check files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes test failure of
database_knotinfoseen in GH Actions, as reported by @soehms in#36668 (comment)
Fixes same also for
database_cubic_heckeandmathics.To test:
FROM_DOCKER_TARGET=with-targets-pre TARGETS_PRE=config.status tox -e docker-ubuntu-bionic-gcc_8-maximal-incremental -- database_knotinfo database_cubic_hecke mathicsWe also remove packages starting with
_from the list of tested packages. The dependencies of_developpulled in the dummy packagegithub_cli.We also use output groups to fold away some repetitive output.
📝 Checklist
⌛ Dependencies