Merged
Conversation
added 7 commits
November 8, 2023 14:02
kwankyu
reviewed
Nov 9, 2023
kwankyu
reviewed
Nov 9, 2023
kwankyu
reviewed
Nov 9, 2023
Collaborator
|
Otherwise, looks good to me. |
added 2 commits
November 8, 2023 16:16
dcoudert
suggested changes
Nov 9, 2023
| sage: # needs sage.rings.number_field | ||
| sage: sqrt_2 = AA(2)^(1/2) | ||
| sage: cbrt_2 = AA(2)^(1/3) | ||
| sage: timeit('Polyhedron(vertices=[[sqrt_2, 0], [0, cbrt_2]])') |
Contributor
There was a problem hiding this comment.
You must put back the tag # random. The CI reports a doctest error:
sage -t --long --random-seed=286735480429121101562228604801325644303 doc/en/thematic_tutorials/geometry/polyhedra_tutorial.rst
**********************************************************************
File "doc/en/thematic_tutorials/geometry/polyhedra_tutorial.rst", line 205, in doc.en.thematic_tutorials.geometry.polyhedra_tutorial
Failed example:
timeit('Polyhedron(vertices=[[sqrt_2, 0], [0, cbrt_2]])')
Expected:
5 loops, best of 3: 43.2 ms per loop
Got:
25 loops, best of 3: 21.9 ms per loop
**********************************************************************
1 item had failures:
1 of 100 in doc.en.thematic_tutorials.geometry.polyhedra_tutorial
[99 tests, 1 failure, 16.62 s]
Contributor
Author
There was a problem hiding this comment.
Thanks for catching this, fixed in f43552e
|
Documentation preview for this PR (built with commit f43552e; changes) is ready! 🎉 |
Contributor
Author
|
Thanks both! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 7, 2023
sagemathgh-36679: `src/doc`: Update `# needs` <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> Also some doctest cosmetics. <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> In part cherry-picked from sagemath#35095. <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36679 Reported by: Matthias Köppe Reviewer(s): David Coudert, Kwankyu Lee, Matthias Köppe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also some doctest cosmetics.
In part cherry-picked from #35095.
📝 Checklist
⌛ Dependencies